Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup and reorg #10434

Merged
merged 2 commits into from
Jan 13, 2025
Merged

cleanup and reorg #10434

merged 2 commits into from
Jan 13, 2025

Conversation

lgadban
Copy link
Contributor

@lgadban lgadban commented Jan 10, 2025

minor cleanup and reorganization to improve readability

nfuden
nfuden approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@nfuden nfuden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Looks like alot of this pr is something that is stylistic choices. Can we find a linter and put it in ci so we can be opinionated and need less changes with regards to things like unrolling function args to multiple lines.

@jenshu jenshu enabled auto-merge January 13, 2025 16:34
@lgadban lgadban force-pushed the law/more-x3-cleanup branch from c42ae0d to d21bbfe Compare January 13, 2025 21:32
@jenshu jenshu added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit 8e35c9f Jan 13, 2025
6 of 15 checks passed
@jenshu jenshu deleted the law/more-x3-cleanup branch January 13, 2025 22:41
@timflannagan timflannagan mentioned this pull request Jan 29, 2025
Open
@lgadban lgadban linked an issue Jan 29, 2025 that may be closed by this pull request
[Epic] Cleanup Repo #10496
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timflannagan timflannagan timflannagan approved these changes

@jenshu jenshu jenshu approved these changes

@nfuden nfuden nfuden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Epic] Cleanup Repo
4 participants
@lgadban @timflannagan @jenshu @nfuden