remove legacy Settings type #10458
Merged
remove legacy Settings type #10458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The controller and deployer had a few dependencies on the legacy Gloo Settings type. This commit removes the usage of the Settings type and KRT collection and replaces it with a 1:1 copy that is non-KRT driven and purely derived from environment variables.
stevenctl
pushed a commit
to stevenctl/gloo
that referenced
this pull request
Jan 15, 2025
Co-authored-by: changelog-bot <changelog-bot> Co-authored-by: Sam Heilbron <[email protected]>
jenshu
reviewed
Jan 16, 2025
jenshu
reviewed
Jan 16, 2025
| ) | ||
|
|
||
| type Settings struct { | ||
| IstioIntegration bool |
There was a problem hiding this comment.
Suggested change
| IstioIntegration bool | |
| EnableIstioIntegration bool |
|
fixes #10445 |
timflannagan
approved these changes
Jan 16, 2025
Yes definitely. There is an existing helm API for this, so I would imagine as we look for which features to port over, this needs to be one of them. A specific line-item sounds like a good idea! |
yuval-k
approved these changes
Jan 16, 2025
timflannagan
added a commit
to timflannagan/kgateway
that referenced
this pull request
Jan 23, 2025
This removes the Settings CR from the setup.yaml bootstrap configuration in the envtests. The kgateway chart does not carry this CR over to it's crds/ directory or have the RBAC permissions to watch, list, etc. the resource. Previously, we removed the legacy Settings logic in the gateway2 control plane in kgateway-dev#10458, so this resource is no longer necessary in the setup.yaml and envtest fails trying to deploy it with the new chart. Signed-off-by: timflannagan <[email protected]>
timflannagan
added a commit
to timflannagan/kgateway
that referenced
this pull request
Jan 24, 2025
This removes the Settings CR from the setup.yaml bootstrap configuration in the envtests. The kgateway chart does not carry this CR over to it's crds/ directory or have the RBAC permissions to watch, list, etc. the resource. Previously, we removed the legacy Settings logic in the gateway2 control plane in kgateway-dev#10458, so this resource is no longer necessary in the setup.yaml and envtest fails trying to deploy it with the new chart. Signed-off-by: timflannagan <[email protected]>
Closed
Closed
timflannagan
added a commit
to timflannagan/kgateway
that referenced
this pull request
Jan 24, 2025
This removes the Settings CR from the setup.yaml bootstrap configuration in the envtests. The kgateway chart does not carry this CR over to it's crds/ directory or have the RBAC permissions to watch, list, etc. the resource. Previously, we removed the legacy Settings logic in the gateway2 control plane in kgateway-dev#10458, so this resource is no longer necessary in the setup.yaml and envtest fails trying to deploy it with the new chart. Signed-off-by: timflannagan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The controller and deployer had a few dependencies on the legacy Gloo Settings type. This commit removes the usage of the Settings type and KRT collection and replaces it with a 1:1 copy that is non-KRT driven and purely derived from environment variables.
These can be set with "KGW_" prefixing the setting name (from the struct)
e.g.
Testing
As e2e testing is currently broken, this can be manually tested by setting the appropriate env vars on the deployment
While e2e testing is disable, the ggv2test envtests DO test with istio features enabled, so we do have some proof the feature still works