Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Add the -local goimports flag to the fmt Makefile target #10486

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

timflannagan
Copy link
Member

Description

Update the "fmt" Makefile target and enable the -local goimports CLI flag. Previously, there was a TODO comment in the fmt-v2 target the mentioned the want/need to do this in the long term. This commit purges the fmt-v2 target & update the fmt target to provide the desired goimports flag. This provides a consistent module structure throughout the repository:

  • Standard library dependencies
  • Third party dependencies (note: over time, this will include github.com/solo-io dependencies that aren't ported over)
  • Local code in the root module path

Partially related to #10444 which is tracking the root Go module name change. We'll need to also change that in the Makefile once we're closer with that stream of work.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@timflannagan timflannagan changed the title Chore/add goimports local flag *: Add the -local goimports flag to the fmt Makefile target Jan 22, 2025
@timflannagan timflannagan force-pushed the chore/add-goimports-local-flag branch from 45d641d to 67f537e Compare January 30, 2025 18:52
Copy link
Contributor

@lgadban lgadban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing

@lgadban lgadban added this pull request to the merge queue Jan 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 30, 2025
@timflannagan
Copy link
Member Author

@lgadban Looks like there was merge conflicts that I resolved in the latest merge commit.

@jenshu jenshu added this pull request to the merge queue Jan 31, 2025
Merged via the queue into kgateway-dev:main with commit e168b0a Jan 31, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants