Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove cilium from setup-kind script #10551

Merged
merged 1 commit into from
Jan 30, 2025
Merged

remove cilium from setup-kind script #10551

merged 1 commit into from
Jan 30, 2025

Conversation

jenshu
Copy link
Contributor

@jenshu jenshu commented Jan 29, 2025

this was used for testing; not needed for now as we don't currently support leader election

timflannagan
timflannagan approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@timflannagan timflannagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, this was needed to simulate API server disruptions (as chaos mesh cannot do that) and we never invested further into a proper chaos testing suite. Is it worth creating a tracker for a chaos testing suite?

@jenshu
Copy link
Contributor Author

jenshu commented Jan 29, 2025 •
edited
Loading

Is it worth creating a tracker for a chaos testing suite?

good idea! #9638 exists but is edge-specific (and should probably be moved out of this repo). @timflannagan do you want to create a new issue for kgateway chaos testing? edit: created #10552

nfuden
nfuden approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@nfuden nfuden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see the continued paring down of deps!

@jenshu jenshu added this pull request to the merge queue Jan 30, 2025
Merged via the queue into kgateway-dev:main with commit 2e2dd9e Jan 30, 2025
8 checks passed
@jenshu jenshu deleted the remove-cilium branch January 30, 2025 15:13
@jenshu jenshu mentioned this pull request Jan 30, 2025
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timflannagan timflannagan timflannagan approved these changes

@nfuden nfuden nfuden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenshu @timflannagan @nfuden