.github: Update main branch version to v2.0.0-main #10581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: timflannagan <[email protected]>
|
Testing this in my fork first. Let's figure out any gaps with this tagging structure and whether there's any impact to module imports with v2+ versions. |
timflannagan
commented
Feb 5, 2025
There was a problem hiding this comment.
TODO: Need to update the "v0.0.0-main" reference in the release notes conditional too. See https://github.com/timflannagan/kgateway/releases/tag/v2.0.0-main.
yuval-k
approved these changes
Feb 6, 2025
jenshu
approved these changes
Feb 6, 2025
| @@ -4,7 +4,7 @@ on: | |||
| push: | |||
| tags: | |||
| - 'v*' | |||
| - '!v0.0.0-main' | |||
| - '!v2.0.0-main' | |||
There was a problem hiding this comment.
will this stay at 2.0.0-main as long as we are on 2.x? or do we need to update to 2.1.0-main etc, in the future?
Signed-off-by: timflannagan <[email protected]>
jenshu
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace the v0.0.0-main tagging convention that was introduced with the #10540 changes in favor of the v2.0.0-main tag in the release GHA workflow. Previously, the v0.0.0-main tag was a introduced as 1. a workaround to helm chart requiring valid semver tags, and 2. a placeholder until we formed consensus around the desired tagging convention going forward.
Related to #10559.
Checklist: