Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Rename the gateway2 -> kgateway #10602

Merged

Conversation

timflannagan
Copy link
Member

Description

This is a follow-up to #10498 to rename the legacy "gateway2" directory. As mentioned in the commit description, this name is an artifact from the Gloo repository where multiple controller plane implementations needed to be maintained in parallel.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

The "gateway2" directory naming was an artifact from the
previous Gloo project where multiple gateway implementations
needed to be supported & is no longer relevant to this
project's scope.

When talking with a group of maintainers, there was less
of an appetite for a "controller" directory, in order to
remain consistent with the current helm chart naming,
underlying deployment/pod name, etc.

Signed-off-by: timflannagan <[email protected]>
@timflannagan timflannagan changed the title *: Rename the internal/gateway2 -> internal/kgateway *: Rename the gateway2 -> kgateway Feb 10, 2025
@timflannagan timflannagan force-pushed the chore/rename-gw2-directory branch 2 times, most recently from a537b95 to c681797 Compare February 10, 2025 22:15
@timflannagan timflannagan force-pushed the chore/rename-gw2-directory branch from c681797 to ed53f3d Compare February 10, 2025 22:24
@npolshakova npolshakova added this pull request to the merge queue Feb 11, 2025
Merged via the queue into kgateway-dev:main with commit 6237f12 Feb 11, 2025
9 checks passed
@timflannagan timflannagan deleted the chore/rename-gw2-directory branch February 11, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants