Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the examples/ directory #10623

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Update the examples/ directory #10623

merged 3 commits into from
Feb 13, 2025

Conversation

timflannagan
Copy link
Member

Description

Quick cleanup PR that touches the examples/ directory

  • The DirectResponse example referenced the gloo-system namespace and was overall broken. I ripped out the namespace parameter to remain consistent with the rest of the examples
  • Removed the legacy helm chart value overrides
  • Removed the GW API relates resources from the httpbin.yaml file to make it purely scoped to installing the httpbin app

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@timflannagan
examples: Remove namespace from direct response example
dfcb7e8 
Signed-off-by: timflannagan <[email protected]>
@timflannagan
examples: Remove legacy helm chart values
f478cc5 
Signed-off-by: timflannagan <[email protected]>
@timflannagan
examples: Rip out GW API resources from httpbin.yaml
fe5f55b 
- Keep this file focused on installing the httpbin app

- Other example(s) can be used to create the GW API resources

Signed-off-by: timflannagan <[email protected]>
@timflannagan timflannagan added this pull request to the merge queue Feb 13, 2025
Merged via the queue into kgateway-dev:main with commit 4dbdede Feb 13, 2025
9 checks passed
@timflannagan timflannagan deleted the chore/update-example-system-namespace branch February 13, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenshu jenshu jenshu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timflannagan @jenshu