Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add predeclared linter #9047

Merged
merged 8 commits into from
Jan 16, 2024
Merged

Conversation

jbohanon
Copy link
Contributor

@jbohanon jbohanon commented Jan 9, 2024

Description

Add predeclared linter to guard against shadowing builtins.

@solo-changelog-bot
Copy link

Issues linked to changelog:
solo-io#6686

@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Jan 9, 2024
@jbohanon jbohanon mentioned this pull request Jan 9, 2024
@jbohanon jbohanon changed the base branch from main to jbohanon/add-linters January 9, 2024 20:46
@jbohanon jbohanon force-pushed the jbohanon/add-linter-predeclared branch from 72206df to a6969eb Compare January 9, 2024 20:46
@jbohanon
Copy link
Contributor Author

jbohanon commented Jan 9, 2024

/skip-changelog

jenshu
jenshu previously approved these changes Jan 9, 2024
@jbohanon jbohanon changed the base branch from jbohanon/add-linters to main January 16, 2024 02:59
@jbohanon jbohanon dismissed jenshu’s stale review January 16, 2024 02:59

The base branch was changed.

@jbohanon jbohanon removed the keep pr updated signals bulldozer to keep pr up to date with base branch label Jan 16, 2024
@soloio-bulldozer soloio-bulldozer bot merged commit 9cb85cc into main Jan 16, 2024
14 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the jbohanon/add-linter-predeclared branch January 16, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants