gnome-shell 3.34 crash on audio source removal

[pd5rm]

I got the following crash, don't know if this extension was the source, but figured since it was audio related it might be.

On Arch, running gnome-shell 1:3.34.0+94+g3d86e6e79-1.
I think I'm running extension 3.34, 23.
The extensions show with error symbol on https://extensions.gnome.org/extension/906/sound-output-device-chooser/ display.

I believe the error occured when I turned off my bluetooth headphones.

       Message: Process 1329 (gnome-shell) of user 16430 dumped core.
                
                Stack trace of thread 1329:
                #0  0x00007fa9315b3804 gvc_mixer_ui_device_get_active_profile (libgvc.so)
                #1  0x00007fa950ca06d0 ffi_call_unix64 (libffi.so.6)
                #2  0x00007fa950ca00a0 ffi_call (libffi.so.6)
                #3  0x00007fa951de3b75 n/a (libgjs.so.0)
                #4  0x00007fa951de595c n/a (libgjs.so.0)
                #5  0x00002994ce23a855 n/a (n/a)
                #6  0x00005642fd5fa4b8 n/a (n/a)
                #7  0x00002994ce23bab1 n/a (n/a)
                #8  0x00005642ff33f8c8 n/a (n/a)
                #9  0x00002994ce23bab1 n/a (n/a)
                #10 0x00005642fd09f148 n/a (n/a)
                #11 0x00002994ce2324e8 n/a (n/a)
                #12 0x00007fa94ef8c37b n/a (libmozjs-60.so.0)
                #13 0x00007fa94edb3a3d n/a (libmozjs-60.so.0)
                #14 0x00007fa94edb41cf n/a (libmozjs-60.so.0)
                #15 0x00007fa94edb481f n/a (libmozjs-60.so.0)
                #16 0x00007fa94f159080 _Z15JS_CallFunctionP9JSContextN2JS6HandleIP8JSObjectEENS2_IP10JSFunctionEERKNS1_16HandleValueArrayENS1_13MutableHandleI>
                #17 0x00007fa951dde06b _Z18gjs_closure_invokeP9_GClosureN2JS6HandleIP8JSObjectEERKNS1_16HandleValueArrayENS1_13MutableHandleINS1_5ValueEEEb (l>
                #18 0x00007fa951e05cb1 n/a (libgjs.so.0)
                #19 0x00007fa95272cd3a g_closure_invoke (libgobject-2.0.so.0)
                #20 0x00007fa9527195cf n/a (libgobject-2.0.so.0)
                #21 0x00007fa95263fa74 n/a (libglib-2.0.so.0)
                #22 0x00007fa95264027f g_main_context_dispatch (libglib-2.0.so.0)
                #23 0x00007fa9526421c1 n/a (libglib-2.0.so.0)
                #24 0x00007fa9526430d3 g_main_loop_run (libglib-2.0.so.0)
                #25 0x00007fa951a9bbbc meta_run (libmutter-5.so.0)
                #26 0x00005642f82b4436 n/a (gnome-shell)
                #27 0x00007fa952b7eee3 __libc_start_main (libc.so.6)
                #28 0x00005642f82b462e n/a (gnome-shell)

[kgshank]

Can you test code from GitHub? Mainloop related code is removed in the git version. I have not yet uploaded it to extensions site. One affected area is exactly for device removal.

[felixls]

@kgshank worked for me on Arch cloning master @ 886a85a

[kgshank]

Thanks for the feedback, uploaded new version to extensions site

[felixls]

@kgshank Ups no so fast, I got duplicates

[terencode]

@felixls It's being tracked in #41.

[kgshank]

Please test the current commit, duplicate list issue should be fixed now

[pd5rm]

Hi @kgshank,

I just tried with f278705, and had no crasher with add/removal of the bluetooth device. Also, the extension no longers shows up with "error" symbol with this revision.

But I did get a trace when I went into settings panel and hid a source (e.g HDMI). It's possible that may have been the root cause before as well, since I recall I was trying to remove extra audio sources.

   Message: Process 24211 (gnome-shell) of user 16430 dumped core.
            
            Stack trace of thread 24211:
            #0  0x00007f13d370c804 gvc_mixer_ui_device_get_active_profile (libgvc.so)
            #1  0x00007f141b6416d0 ffi_call_unix64 (libffi.so.6)
            #2  0x00007f141b6410a0 ffi_call (libffi.so.6)
            #3  0x00007f141c784b75 n/a (libgjs.so.0)
            #4  0x00007f141c78695c n/a (libgjs.so.0)
            #5  0x00007f1419755265 n/a (libmozjs-60.so.0)
            #6  0x00007f141985e30f n/a (libmozjs-60.so.0)
            #7  0x000038f6d448845b n/a (n/a)
            #8  0x000055be56ed0438 n/a (n/a)
            #9  0x000038f6d44834e8 n/a (n/a)
            #10 0x00007f141992d37b n/a (libmozjs-60.so.0)
            #11 0x00007f1419754a3d n/a (libmozjs-60.so.0)
            #12 0x00007f14197551cf n/a (libmozjs-60.so.0)
            #13 0x00007f1419746882 n/a (libmozjs-60.so.0)
            #14 0x00007f1419754aa6 n/a (libmozjs-60.so.0)
            #15 0x00007f14197551cf n/a (libmozjs-60.so.0)
            #16 0x00007f141975581f n/a (libmozjs-60.so.0)
            #17 0x00007f1419a7343e n/a (libmozjs-60.so.0)
            #18 0x00007f1419a7388c n/a (libmozjs-60.so.0)
            #19 0x000038f6d4483f87 n/a (n/a)
            #20 0x000055be61c060f0 n/a (n/a)
            #21 0x000038f6d44834e8 n/a (n/a)
            #22 0x00007f141992d37b n/a (libmozjs-60.so.0)
            #23 0x00007f1419754a3d n/a (libmozjs-60.so.0)
            #24 0x00007f14197551cf n/a (libmozjs-60.so.0)
            #25 0x00007f141975581f n/a (libmozjs-60.so.0)
            #26 0x00007f1419afa080 _Z15JS_CallFunctionP9JSContextN2JS6HandleIP8JSObjectEENS2_IP10JSFunctionEERKNS1_16HandleValueArrayENS1_13MutableHandleINS1_5ValueEEE (libmozjs-60.so.0)
            #27 0x00007f141c77f06b _Z18gjs_closure_invokeP9_GClosureN2JS6HandleIP8JSObjectEERKNS1_16HandleValueArrayENS1_13MutableHandleINS1_5ValueEEEb (libgjs.so.0)
            #28 0x00007f141c7a6cb1 n/a (libgjs.so.0)
            #29 0x00007f141d0cdd3a g_closure_invoke (libgobject-2.0.so.0)
            #30 0x00007f141d0bb88e n/a (libgobject-2.0.so.0)
            #31 0x00007f141d0bf98a g_signal_emit_valist (libgobject-2.0.so.0)
            #32 0x00007f141d0c07f0 g_signal_emit (libgobject-2.0.so.0)
            #33 0x00007f141d17f1d3 n/a (libgio-2.0.so.0)
            #34 0x00007f141d1e0b15 n/a (libgio-2.0.so.0)
            #35 0x00007f141d0bfb4a g_signal_emit_valist (libgobject-2.0.so.0)
            #36 0x00007f141d0c07f0 g_signal_emit (libgobject-2.0.so.0)
            #37 0x00007f141d17caef n/a (libgio-2.0.so.0)
            #38 0x00007f141d17a35b n/a (libgio-2.0.so.0)
            #39 0x00007f141cfe127f g_main_context_dispatch (libglib-2.0.so.0)
            #40 0x00007f141cfe31c1 n/a (libglib-2.0.so.0)
            #41 0x00007f141cfe40d3 g_main_loop_run (libglib-2.0.so.0)
            #42 0x00007f141c43cc2c meta_run (libmutter-5.so.0)
            #43 0x000055be5491e436 n/a (gnome-shell)
            #44 0x00007f141d51fee3 __libc_start_main (libc.so.6)
            #45 0x000055be5491e62e n/a (gnome-shell)