Skip to content

Commit

Permalink
remove configGuice half
Browse files Browse the repository at this point in the history
  • Loading branch information
kgyrtkirk committed Dec 16, 2024
1 parent 2e5b0ac commit aab6f5a
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ public ExportComponentSupplier(TempDirProducer tempFolderProducer)
}

@Override
public void configureGuice(DruidInjectorBuilder builder)
public void configureGuice(DruidInjectorBuilder builder, List<com.google.inject.Module> overrideModules)
{
super.configureGuice(builder);
super.configureGuice(builder, overrideModules);
builder.addModule(
new DruidModule()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,9 @@ public SqlEngine createEngine(QueryLifecycleFactory qlf, ObjectMapper queryJsonM
}

@Override
public void configureGuice(DruidInjectorBuilder builder)
public void configureGuice(DruidInjectorBuilder builder, List<com.google.inject.Module> overrideModules)
{
super.configureGuice(builder);
super.configureGuice(builder, overrideModules);

builder.addModule(new DruidModule() {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,9 @@ public NestedComponentSupplier(TempDirProducer tempFolderProducer)
}

@Override
public void configureGuice(DruidInjectorBuilder builder)
public void configureGuice(DruidInjectorBuilder builder, List<com.google.inject.Module> overrideModules)
{
super.configureGuice(builder);
super.configureGuice(builder, overrideModules);
}

@SuppressWarnings("resource")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -344,12 +344,6 @@ public void gatherProperties(Properties properties)
{
}

public void configureGuice(DruidInjectorBuilder builder)
{
// This shell exists to minimize changes to child classes. This method should probably be removed and
// places that extend this just updated, but that generates a lot of changes that could introduce conflicts
}

@Override
public void configureGuice(DruidInjectorBuilder builder, List<Module> overrideModules)
{
Expand All @@ -365,7 +359,6 @@ public void configureGuice(DruidInjectorBuilder builder, List<Module> overrideMo
.to(SpecificSegmentsQuerySegmentWalker.class)
.in(LazySingleton.class)
);
configureGuice(builder);
}

@Override
Expand Down

0 comments on commit aab6f5a

Please sign in to comment.