Load the web app for chat, search from the Desktop app #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The desktop app specific chat, search pages were removed in #994. This changes loads the web app chat, search pages fromthe Desktop app. This deduplicates the development effort to maintain a separate set of pages for the desktop app while still giving the same functionality
sabaimran
reviewed
Jan 15, 2025
| @@ -735,6 +742,8 @@ app.whenReady().then(() => { | |||
| tray = new Tray(icon) | |||
|
|
|||
| const contextMenu = Menu.buildFromTemplate([ | |||
| { label: 'Chat', type: 'normal', click: () => { openWindow(); }}, | |||
There was a problem hiding this comment.
We should also add the home page, agents, automations, settings, as well right? Otherwise the links would be broken. I'm not sure if they'll all work either as intended.
There was a problem hiding this comment.
These menu tray actions I added were just the main entry points (consistent with previous behavior). Adding all the top level web app pages to the system tray maybe too many items? The web app links all work consistently internally so you can reach the rest of the pages from the chat, search pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The desktop app specific chat, search pages were removed in #994.
This changes loads the web app chat, search pages fromthe Desktop app.
This deduplicates the development effort to maintain a separate set of
pages for the desktop app while still giving similar functionality.