Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/spf13/cobra from 1.6.1 to 1.9.1 #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Feb 17, 2025

Bumps github.com/spf13/cobra from 1.6.1 to 1.9.1.

Release notes

Sourced from github.com/spf13/cobra's releases.

v1.9.1

🐛 Fixes

Full Changelog: spf13/cobra@v1.9.0...v1.9.1

v1.9.0

✨ Features

🐛 Fixes

🤖 Completions

🧪 Testing

✍🏼 Documentation

🔧 Dependency upgrades

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by Sourcery

Update spf13/cobra from 1.6.1 to 1.9.1. This change includes new features such as a default completion command and a CompletionWithDesc helper, several bug fixes, completion enhancements, documentation updates, dependency upgrades, and testing improvements.

New Features:

  • Add default completion command even if there are no other sub-commands
  • Add CompletionWithDesc helper

Bug Fixes:

  • Fix CompletionFunc implementation.
  • Revert "Make detection for test-binary more universal (#2173)"
  • Fix deprecation comment for Command.SetOutput
  • Replace deprecated ioutil usage
  • Fix --version help and output for plugins
  • Allow to reset the templates to the default

Enhancements:

  • Allow linker to perform deadcode elimination for program using Cobra

Build:

  • Bump github.com/cpuguy83/go-md2man/v2 from 2.0.5 to 2.0.6
  • Update to latest go-md2man

Documentation:

  • Update README.md
  • Improve site formatting
  • Add Conduit
  • Add azion project to the list of CLIs that use cobra
  • Fix broken links in active_help.md

Tests:

  • Test also with go 1.23
  • Make detection for test-binary more universal

Chores:

  • Upgrade dependencies for v1.9.0
  • Fix function name in comment

Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.6.1 to 1.9.1.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.6.1...v1.9.1)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Feb 17, 2025
Copy link

sourcery-ai bot commented Feb 17, 2025

Reviewer's Guide by Sourcery

This pull request bumps the github.com/spf13/cobra dependency from v1.6.1 to v1.9.1. It also updates github.com/spf13/pflag and github.com/inconshreveable/mousetrap.

Sequence diagram for command completion with description

sequenceDiagram
    participant User
    participant Shell
    participant CobraApp
    participant Command

    User->>Shell: Enters command with completion
    Shell->>CobraApp: Requests completion suggestions
    CobraApp->>Command: Executes CompletionFunc
    Command->>Command: Generates completion suggestions with descriptions
    Command-->>CobraApp: Returns completion suggestions
    CobraApp-->>Shell: Returns completion suggestions
    Shell-->>User: Displays completion suggestions
Loading

Updated class diagram for Cobra Command

classDiagram
  class Command {
    +Use string
    +Short string
    +Long string
    +RunE func(cmd *Command, args []string) error
    +CompletionFunc func(cmd *Command, args []string) ([]string, Directive)
    +SetOutput(io.Writer)
    +ResetFlags()
  }
  note for Command "CompletionFunc added to Command class"
Loading

File-Level Changes

Change Details Files
Bumped the cobra and pflag dependencies.
  • Updated github.com/spf13/cobra from 1.6.1 to 1.9.1.
  • Updated github.com/spf13/pflag from 1.0.5 to 1.0.6.
  • Updated github.com/inconshreveable/mousetrap from 1.0.1 to 1.1.0.
go.mod
go.sum

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

coderabbitai bot commented Feb 17, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, dependabot[bot]!). We assume it knows what it's doing!

Copy link

codiumai-pr-agent-free bot commented Feb 17, 2025

CI Feedback 🧐

(Feedback updated until commit 60cd5ef)

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: Run Go tests (ubuntu-latest)

Failed stage: Run make test [❌]

Failed test name: Test_Ignores, Test_Flag_IncludeIgnored, Test_Flag_CustomCheckUrlNotFound, Test_Flag_CustomCheckUrl, Test_Issue_1661

Failure summary:

The test suite failed with 5 failing tests:
1. Test_Ignores: Expected 0 items but found 9 AWS S3
security rules
2. Test_Flag_IncludeIgnored: Expected 0 but got 1
3.
Test_Flag_CustomCheckUrlNotFound: Expected 43 items but found 45 security rules
4.
Test_Flag_CustomCheckUrl: Expected 55 items but found 57 security rules
5. Test_Issue_1661: Failed
because results incorrectly contained 'aws-rds-enable-performance-insights-encryption' rule

The failures appear to be related to incorrect counts of security rules being applied or ignored in
various test scenarios.

Relevant error logs:
1:  ##[group]Operating System
2:  Ubuntu
...

654:  go: downloading github.com/hashicorp/go-uuid v1.0.3
655:  go: downloading github.com/mitchellh/go-homedir v1.1.0
656:  go: downloading github.com/agext/levenshtein v1.2.3
657:  go: downloading github.com/apparentlymart/go-textseg/v13 v13.0.0
658:  go: downloading github.com/mitchellh/go-wordwrap v1.0.1
659:  go: downloading github.com/mattn/go-colorable v0.1.12
660:  go: downloading github.com/gdamore/tcell/v2 v2.5.0
661:  go: downloading github.com/OneOfOne/xxhash v1.2.8
662:  go: downloading github.com/pkg/errors v0.9.1
...

694:  go: downloading google.golang.org/protobuf v1.30.0
695:  go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20190905194746-02993c407bfb
696:  go: downloading github.com/agnivade/levenshtein v1.1.1
697:  go: downloading github.com/ProtonMail/go-crypto v0.0.0-20230828082145-3c4c8a2d2371
698:  go: downloading github.com/emirpasic/gods v1.18.1
699:  go: downloading github.com/sergi/go-diff v1.1.0
700:  go: downloading dario.cat/mergo v1.0.0
701:  go: downloading go.opencensus.io v0.24.0
702:  go: downloading golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2
...

723:  �[32m✓�[0m  internal/pkg/custom (2.767s)
724:  �[33m∅�[0m  internal/pkg/formatter
725:  �[33m∅�[0m  internal/pkg/ignores
726:  �[33m∅�[0m  internal/pkg/legacy
727:  �[33m∅�[0m  internal/pkg/metrics
728:  �[33m∅�[0m  internal/pkg/updater
729:  �[31m✖�[0m  test (2m41.186s)
730:  �[33m∅�[0m  version
731:  === �[31mFailed�[0m
732:  === �[31mFAIL�[0m: test Test_Ignores (2.12s)
733:  defaults_test.go:71: 
734:  Error Trace:	/home/runner/work/tfsecurity/tfsecurity/test/defaults_test.go:71
735:  Error:      	"[{ aws-s3-block-public-acls      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-block-public-policy      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-bucket-encryption      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-ignore-public-acls      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-no-public-buckets      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-encryption-customer-key      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-bucket-logging      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-versioning      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-specify-public-access-block      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}}]" should have 0 item(s), but has 9
736:  Test:       	Test_Ignores
737:  defaults_test.go:72: 
738:  Error Trace:	/home/runner/work/tfsecurity/tfsecurity/test/defaults_test.go:72
739:  Error:      	Not equal: 
740:  expected: 0
741:  actual  : 1
742:  Test:       	Test_Ignores
743:  === �[31mFAIL�[0m: test Test_Flag_IncludeIgnored (2.15s)
744:  flags_test.go:376: 
745:  Error Trace:	/home/runner/work/tfsecurity/tfsecurity/test/flags_test.go:376
746:  Error:      	Not equal: 
747:  expected: 0
748:  actual  : 1
749:  Test:       	Test_Flag_IncludeIgnored
750:  === �[31mFAIL�[0m: test Test_Flag_CustomCheckUrlNotFound (2.40s)
751:  flags_test.go:500: 
752:  Error Trace:	/home/runner/work/tfsecurity/tfsecurity/test/flags_test.go:500
753:  Error:      	"[{ aws-ec2-enforce-http-token-imds      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-ec2-enable-at-rest-encryption      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-ec2-enforce-http-token-imds      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-ec2-enable-at-rest-encryption      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-block-public-acls      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-block-public-policy      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-bucket-encryption      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-ignore-public-acls      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-no-public-buckets      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-encryption-customer-key      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-block-public-acls      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-block-public-policy      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-bucket-encryption      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-ignore-public-acls      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-no-public-buckets      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-encryption-customer-key      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-block-public-acls      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-block-public-policy      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-bucket-encryption      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-ignore-public-acls      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-no-public-buckets      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-encryption-customer-key      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-block-public-acls      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-block-public-policy      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-bucket-encryption      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-ignore-public-acls      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-no-public-buckets      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-encryption-customer-key      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-block-public-acls      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-block-public-policy      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-bucket-encryption      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-ignore-public-acls      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-no-public-buckets      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-encryption-customer-key      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-bucket-logging      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-versioning      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-bucket-logging      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-bucket-logging      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-bucket-logging      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-bucket-logging      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-specify-public-access-block      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-specify-public-access-block      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-specify-public-access-block      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-specify-public-access-block      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-specify-public-access-block      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}}]" should have 43 item(s), but has 45
754:  Test:       	Test_Flag_CustomCheckUrlNotFound
755:  === �[31mFAIL�[0m: test Test_Flag_CustomCheckUrl (2.29s)
756:  flags_test.go:510: 
757:  Error Trace:	/home/runner/work/tfsecurity/tfsecurity/test/flags_test.go:510
758:  Error:      	"[{ custom-custom-cus001      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-ec2-enforce-http-token-imds      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-ec2-enable-at-rest-encryption      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { custom-custom-cus007      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-ec2-enforce-http-token-imds      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-ec2-enable-at-rest-encryption      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { custom-custom-cus004      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-block-public-acls      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-block-public-policy      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-bucket-encryption      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-ignore-public-acls      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-no-public-buckets      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-encryption-customer-key      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { custom-custom-cus004      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-block-public-acls      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-block-public-policy      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-bucket-encryption      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-ignore-public-acls      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-no-public-buckets      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-encryption-customer-key      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { custom-custom-cus004      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-block-public-acls      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-block-public-policy      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-bucket-encryption      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-ignore-public-acls      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-no-public-buckets      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-encryption-customer-key      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { custom-custom-cus005      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { custom-custom-cus003      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-block-public-acls      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-block-public-policy      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-bucket-encryption      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-ignore-public-acls      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-no-public-buckets      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-encryption-customer-key      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-block-public-acls      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-block-public-policy      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-bucket-encryption      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-ignore-public-acls      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-no-public-buckets      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-encryption-customer-key      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { custom-custom-cus002      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-bucket-logging      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-versioning      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { custom-custom-cus002      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-bucket-logging      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { custom-custom-cus002      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-bucket-logging      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { custom-custom-cus002      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-bucket-logging      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { custom-custom-cus002      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-enable-bucket-logging      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-specify-public-access-block      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-specify-public-access-block      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-specify-public-access-block      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-specify-public-access-block      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}} { aws-s3-specify-public-access-block      []    %!s(bool=false) %!s(scan.Status=0)  { %!s(int=0) %!s(int=0)}}]" should have 55 item(s), but has 57
759:  Test:       	Test_Flag_CustomCheckUrl
760:  === �[31mFAIL�[0m: test Test_Issue_1661 (2.18s)
761:  setup_test.go:195: 
762:  Error Trace:	/home/runner/work/tfsecurity/tfsecurity/test/setup_test.go:195
763:  /home/runner/work/tfsecurity/tfsecurity/test/issues_test.go:14
764:  Error:      	Should be false
765:  Test:       	Test_Issue_1661
766:  Messages:   	results should not have contained 'aws-rds-enable-performance-insights-encryption'
767:  DONE 131 tests, 5 failures in 220.814s
768:  make: *** [Makefile:14: test] Error 1
769:  ##[error]Process completed with exit code 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants