First implementation to search for shifter #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed how the htcondor job wrapper searches for a container. Instead of assuming singularity now searches through a list to be expanded later. Singularity is still hardcoded with arguments.
khurtado
reviewed
Apr 18, 2019
khurtado
reviewed
Apr 19, 2019
Erroneously left out shifter in module search list, fixed incorrect usage of cntr_path in job_wrapper.
To account for environments with bash versions > 4.0 associative arrays in job_wrapper for htcondor were removed and replaced with simple arrays. Adjusted call to modules within job_wrapper due to failure on Blue Waters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that back end job execution is still hardcoded for singularity arguments. This is a work in progress.