Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grant kiali role list permissions for mutating webhooks #279

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Grant kiali role list permissions for mutating webhooks #279

merged 1 commit into from
Sep 9, 2024

Conversation

nrfox
Copy link
Contributor

@nrfox nrfox commented Sep 3, 2024

This is necessary to read tags in the cluster.

@nrfox nrfox mentioned this pull request Sep 3, 2024
Merged
@nrfox nrfox marked this pull request as ready for review September 4, 2024 10:51
@jshaughn jshaughn requested a review from jmazzitelli September 5, 2024 16:43
jmazzitelli
jmazzitelli previously approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@jmazzitelli jmazzitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, don't forget to add these to the OLM CSVs, also (the operator needs these when installed by OLM, hence the need for OLM CSVs to get updated). See my comment in the operator PR for details.

jmazzitelli
jmazzitelli approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@jmazzitelli jmazzitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seams to luk ok - problmes fixed

@nrfox
Grant kiali role list permissions for mutating webhooks
be0885d 
This is necessary to read tags in the cluster.
jmazzitelli
jmazzitelli approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@jmazzitelli jmazzitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me, in conjunction with the server PR

@nrfox nrfox merged commit 7a6d5b7 into kiali:master Sep 9, 2024
1 check passed
@nrfox nrfox deleted the tag-support branch September 9, 2024 20:46
@nrfox nrfox mentioned this pull request Oct 3, 2024
Merged
gg-techops pushed a commit to giffgaff/kiali-charts that referenced this pull request Feb 17, 2025
@nrfox @jshbrntt
Grant kiali role list permissions for mutating webhooks (kiali#279)
76bffb8 
This is necessary to read tags in the cluster.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmazzitelli jmazzitelli jmazzitelli approved these changes

Assignees

@nrfox nrfox

Labels
None yet
Projects
Kiali Sprint 25-04 | Kiali v2.7
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nrfox @jmazzitelli