add true can-i check to make sure the operator has the permissions it needs #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmazzitelli
force-pushed
the
can-i-check-3241
branch
from
4b69e22 to
1cb2c0f
Compare
jmazzitelli
force-pushed
the
can-i-check-3241
branch
from
1cb2c0f to
c865eed
Compare
|
test with the operator PR. See test procedures here: kiali/kiali-operator#307 (comment) |
… needs for clusterrole/binding creation part of fix for: kiali/kiali#3241
jmazzitelli
force-pushed
the
can-i-check-3241
branch
from
c865eed to
173bab8
Compare
leandroberetta
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of fix for: kiali/kiali#3241
Do NOT merge until we can first merge kiali/kiali-operator#307 (read the description to see what we are waiting for - basically we need community.kubernetes collection v.1.1+) UPDATE: we can merge this now