Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be able to set custom env vars on server pod #829

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

jmazzitelli
Copy link
Contributor

@jmazzitelli jmazzitelli marked this pull request as ready for review October 16, 2024 11:03
@jmazzitelli
Copy link
Contributor Author

jmazzitelli commented Oct 16, 2024

To test, build and push the images and run the molecule test config-values-test:

hack/k8s-minikube.sh start && \
hack/k8s-minikube.sh istio && \
make -e CLUSTER_TYPE=minikube cluster-push && \
hack/run-molecule-tests.sh --client-exe "$(which kubectl)"  --minikube-exe $(which minikube) --cluster-type minikube -udi true -at config-values-test

If you would like to do manual testing, create/deploy the operator and Kiali CR (e.g. make -e CLUSTER_TYPE=minikube cluster-push operator-create kiali-create) and then edit the Kiali CR, adding your own spec.deployment.custom_envs to it. Then see that the operator creates the Kiali server pod with those env vars. This is what the molecule test does.

Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this the manual way and it worked.

@jmazzitelli jmazzitelli merged commit cb92483 into kiali:master Oct 16, 2024
1 check passed
@jmazzitelli jmazzitelli deleted the 7569-custom-envs branch October 16, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Support for additional environment variables in deployment
2 participants