Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.26 improved PHP 8.3 compatibility #6

Merged
merged 1 commit into from
Jan 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .idea/inspectionProfiles/Moodle_CodeSniffer.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions .idea/scopes/kialo.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
### v1.0.26 (Build - 2023121501)

* Improved compatibility with future PHP versions.

### v1.0.25 (Build - 2023112901)

* Minor internal improvements
Expand Down
2 changes: 1 addition & 1 deletion development/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Git
* PHP composer (https://getcomposer.org/)
* on macOS you can install via `brew install composer`
* PHP 7.4 or higher
* PHP 7.4 or PHP 8.2
* If you installed composer `brew`, this should already be installed
* Docker (https://www.docker.com/)

Expand Down
18 changes: 18 additions & 0 deletions tests/classes/lti_flow_test.php
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,24 @@ class lti_flow_test extends \advanced_testcase {
*/
private $cmid;

/**
* Copy of $_SERVER superglobal before the test.
* @var array|null
*/
private $server;

/**
* Copy of $_ENV superglobal before the test.
* @var array|null
*/
private $env;

/**
* Copy of $_GET superglobal before the test.
* @var array|null
*/
private $get;

/**
* In production the tool's (Kialo's) public key is downloaded from the platform (Moodle) during the LTI flow.
* For this test we generate a new keypair and override the tool keychain in kialo_config, instead. *
Expand Down
4 changes: 2 additions & 2 deletions version.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
$plugin->component = 'mod_kialo';

// See https://moodledev.io/docs/apis/commonfiles/version.php.
$plugin->version = 2023112901; // Must be incremented for each new release!
$plugin->release = '1.0.25'; // Semantic version.
$plugin->version = 2023121501; // Must be incremented for each new release!
$plugin->release = '1.0.26'; // Semantic version.

// Officially we require PHP 7.4. The first Moodle version that requires this as a minimum is Moodle 4.1.
// But technically this plugin also runs on older Moodle versions, as long as they run on PHP 7.4,
Expand Down