Skip to content

Commit

Permalink
Fix Kibana nav CSS overrides leaking into other plugins (elastic#107973)
Browse files Browse the repository at this point in the history
- Because we were previously not scoping our Kibana CSS overrides, loading the Enterprise Search plugin and then another plugin would cause that CSS to leak
  • Loading branch information
Constance authored and kibanamachine committed Aug 11, 2021
1 parent 9f2f00e commit a07a1ec
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,18 @@
*/

@include euiBreakpoint('m', 'l', 'xl') {
.kbnPageTemplateSolutionNav {
display: flex;
flex-direction: column;
}
.euiSideNav__content {
flex-grow: 1;
display: flex;
flex-direction: column;
justify-content: space-between;
.betaSidebarNotification {
.euiSideNav {
display: flex;
flex-direction: column;

.euiSideNav__content {
flex-grow: 1;
display: flex;
flex-direction: column;
justify-content: space-between;
}
}
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ export const EnterpriseSearchPageTemplate: React.FC<PageTemplateProps> = ({
}}
isEmptyState={isEmptyState && !isLoading}
solutionNav={solutionNav ? { icon: 'logoEnterpriseSearch', ...solutionNav } : undefined}
pageSideBarProps={{ className: 'betaSidebarNotification' }}
>
{setPageChrome}
{readOnlyMode && (
Expand Down

0 comments on commit a07a1ec

Please sign in to comment.