-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[NTV-648] Agnostic Snapshot Testing Between M1 and Intel (#1794)
* trial new snapshots on m1 snapshot testing framework with 0.98 perceptualPrecision * intel failed comparing against m1 recordings of this test. Trying a subview recording. * replaced FBSnapshotVerifyView with assertSnapshot everywhere in Kickstarter-Framework-iOSTests * re-recorded all snapshots with snapshot-testing framework. This is a huge commit. But only because it's a lot of files. The idea being it replaces everything in the `_64` folder which had our old tests that were references in the `FBSnapshotTestCase` dependency. These new screenshots are not going to be in one folder. They will be local to the view they represent, similar to the organization of the `Kickstarter-Framework-iOS` target file structure. It's more ordered than having one giant reference folder because if you need to check the snapshots, it's easier find any given views' subfolder in XCode. Opening that views subfolder in XCode will give you access to the screenshots in that folder, but through Finder. The image files themselves are not included in the XCode project, so it doesn't bloat our project either. * updating a missed set of tests * updated tests not to overwrite each other when using the same assert. * some tests running on Intel did require approximate comparisons, so added perceptual precision to only those classes. Tests now recorded on M1 pass 100% on Intel. * added test for facebook reset password view controller recorded on M1, should pass on CI and locally on Intel. * removed _64 directory, where old screenshots were, remove ios-snapshot-test-case as dependency, updated TestCase class, removed project schema variables. * still using old trait controllers, combos, devices, languages and other features. Mainly because we still cannot enforce a simulator to fail a record if its' not iPhone 8. It'll just have to be common knowledge that iPhone is our recording simulator. Will update the readme. It's already kind of a guarantee because if we record with another simulator, we'd have failing tests one existing tests when the whole suite is run. * updated snapshots on FacebookResetPasswordViewController * Added preferred simulator check, so no tests pass if simulator for scheme is not iPhone 8 iOS 14.5. Same for recording.
- Loading branch information
Showing
4,127 changed files
with
867 additions
and
331 deletions.
The diff you're trying to view is too large. We only load the first 3000 changed files.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+70.2 KB
...er/__Snapshots__/BetaToolsViewControllerTests/testBetaToolsViewController.1.png
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+111 KB
...shots__/CancelPledgeViewControllerTests/testCancelPledge.lang_de_device_pad.png
Oops, something went wrong.
Binary file added
BIN
+69 KB
...ancelPledgeViewControllerTests/testCancelPledge.lang_de_device_phone4_7inch.png
Oops, something went wrong.
Binary file added
BIN
+60.6 KB
.../CancelPledgeViewControllerTests/testCancelPledge.lang_de_device_phone4inch.png
Oops, something went wrong.
Binary file added
BIN
+71.1 KB
...ancelPledgeViewControllerTests/testCancelPledge.lang_de_device_phone5_5inch.png
Oops, something went wrong.
Binary file added
BIN
+73.8 KB
...ancelPledgeViewControllerTests/testCancelPledge.lang_de_device_phone5_8inch.png
Oops, something went wrong.
Binary file added
BIN
+102 KB
...shots__/CancelPledgeViewControllerTests/testCancelPledge.lang_en_device_pad.png
Oops, something went wrong.
Binary file added
BIN
+58.3 KB
...ancelPledgeViewControllerTests/testCancelPledge.lang_en_device_phone4_7inch.png
Oops, something went wrong.
Binary file added
BIN
+50.8 KB
.../CancelPledgeViewControllerTests/testCancelPledge.lang_en_device_phone4inch.png
Oops, something went wrong.
Binary file added
BIN
+62.7 KB
...ancelPledgeViewControllerTests/testCancelPledge.lang_en_device_phone5_5inch.png
Oops, something went wrong.
Binary file added
BIN
+64.1 KB
...ancelPledgeViewControllerTests/testCancelPledge.lang_en_device_phone5_8inch.png
Oops, something went wrong.
Binary file added
BIN
+103 KB
...shots__/CancelPledgeViewControllerTests/testCancelPledge.lang_es_device_pad.png
Oops, something went wrong.
Binary file added
BIN
+59.6 KB
...ancelPledgeViewControllerTests/testCancelPledge.lang_es_device_phone4_7inch.png
Oops, something went wrong.
Binary file added
BIN
+53.3 KB
.../CancelPledgeViewControllerTests/testCancelPledge.lang_es_device_phone4inch.png
Oops, something went wrong.
Binary file added
BIN
+64.4 KB
...ancelPledgeViewControllerTests/testCancelPledge.lang_es_device_phone5_5inch.png
Oops, something went wrong.
Binary file added
BIN
+65.5 KB
...ancelPledgeViewControllerTests/testCancelPledge.lang_es_device_phone5_8inch.png
Oops, something went wrong.
Binary file added
BIN
+105 KB
...shots__/CancelPledgeViewControllerTests/testCancelPledge.lang_fr_device_pad.png
Oops, something went wrong.
Binary file added
BIN
+62.7 KB
...ancelPledgeViewControllerTests/testCancelPledge.lang_fr_device_phone4_7inch.png
Oops, something went wrong.
Binary file added
BIN
+56.5 KB
.../CancelPledgeViewControllerTests/testCancelPledge.lang_fr_device_phone4inch.png
Oops, something went wrong.
Binary file added
BIN
+66.6 KB
...ancelPledgeViewControllerTests/testCancelPledge.lang_fr_device_phone5_5inch.png
Oops, something went wrong.
Binary file added
BIN
+67.7 KB
...ancelPledgeViewControllerTests/testCancelPledge.lang_fr_device_phone5_8inch.png
Oops, something went wrong.
Binary file added
BIN
+110 KB
...shots__/CancelPledgeViewControllerTests/testCancelPledge.lang_ja_device_pad.png
Oops, something went wrong.
Binary file added
BIN
+65.7 KB
...ancelPledgeViewControllerTests/testCancelPledge.lang_ja_device_phone4_7inch.png
Oops, something went wrong.
Binary file added
BIN
+58.3 KB
.../CancelPledgeViewControllerTests/testCancelPledge.lang_ja_device_phone4inch.png
Oops, something went wrong.
Binary file added
BIN
+70.5 KB
...ancelPledgeViewControllerTests/testCancelPledge.lang_ja_device_phone5_5inch.png
Oops, something went wrong.
Binary file added
BIN
+71.7 KB
...ancelPledgeViewControllerTests/testCancelPledge.lang_ja_device_phone5_8inch.png
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+202 KB
...nViewControllerTests/testCategorySelectionViewController.lang_de_device_pad.png
Oops, something went wrong.
Binary file added
BIN
+126 KB
...rollerTests/testCategorySelectionViewController.lang_de_device_phone4_7inch.png
Oops, something went wrong.
Binary file added
BIN
+101 KB
...ntrollerTests/testCategorySelectionViewController.lang_de_device_phone4inch.png
Oops, something went wrong.
Binary file added
BIN
+134 KB
...rollerTests/testCategorySelectionViewController.lang_de_device_phone5_5inch.png
Oops, something went wrong.
Binary file added
BIN
+131 KB
...rollerTests/testCategorySelectionViewController.lang_de_device_phone5_8inch.png
Oops, something went wrong.
Binary file added
BIN
+200 KB
...nViewControllerTests/testCategorySelectionViewController.lang_en_device_pad.png
Oops, something went wrong.
Binary file added
BIN
+118 KB
...rollerTests/testCategorySelectionViewController.lang_en_device_phone4_7inch.png
Oops, something went wrong.
Binary file added
BIN
+100 KB
...ntrollerTests/testCategorySelectionViewController.lang_en_device_phone4inch.png
Oops, something went wrong.
Binary file added
BIN
+130 KB
...rollerTests/testCategorySelectionViewController.lang_en_device_phone5_5inch.png
Oops, something went wrong.
Binary file added
BIN
+123 KB
...rollerTests/testCategorySelectionViewController.lang_en_device_phone5_8inch.png
Oops, something went wrong.
Binary file added
BIN
+205 KB
...nViewControllerTests/testCategorySelectionViewController.lang_es_device_pad.png
Oops, something went wrong.
Binary file added
BIN
+128 KB
...rollerTests/testCategorySelectionViewController.lang_es_device_phone4_7inch.png
Oops, something went wrong.
Binary file added
BIN
+102 KB
...ntrollerTests/testCategorySelectionViewController.lang_es_device_phone4inch.png
Oops, something went wrong.
Binary file added
BIN
+140 KB
...rollerTests/testCategorySelectionViewController.lang_es_device_phone5_5inch.png
Oops, something went wrong.
Binary file added
BIN
+133 KB
...rollerTests/testCategorySelectionViewController.lang_es_device_phone5_8inch.png
Oops, something went wrong.
Binary file added
BIN
+204 KB
...nViewControllerTests/testCategorySelectionViewController.lang_fr_device_pad.png
Oops, something went wrong.
Binary file added
BIN
+128 KB
...rollerTests/testCategorySelectionViewController.lang_fr_device_phone4_7inch.png
Oops, something went wrong.
Binary file added
BIN
+101 KB
...ntrollerTests/testCategorySelectionViewController.lang_fr_device_phone4inch.png
Oops, something went wrong.
Binary file added
BIN
+140 KB
...rollerTests/testCategorySelectionViewController.lang_fr_device_phone5_5inch.png
Oops, something went wrong.
Binary file added
BIN
+134 KB
...rollerTests/testCategorySelectionViewController.lang_fr_device_phone5_8inch.png
Oops, something went wrong.
Binary file added
BIN
+210 KB
...nViewControllerTests/testCategorySelectionViewController.lang_ja_device_pad.png
Oops, something went wrong.
Binary file added
BIN
+128 KB
...rollerTests/testCategorySelectionViewController.lang_ja_device_phone4_7inch.png
Oops, something went wrong.
Binary file added
BIN
+103 KB
...ntrollerTests/testCategorySelectionViewController.lang_ja_device_phone4inch.png
Oops, something went wrong.
Binary file added
BIN
+141 KB
...rollerTests/testCategorySelectionViewController.lang_ja_device_phone5_5inch.png
Oops, something went wrong.
Binary file added
BIN
+133 KB
...rollerTests/testCategorySelectionViewController.lang_ja_device_phone5_8inch.png
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.