Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable aggregate status check #2

Conversation

kidrahahjo
Copy link
Owner

@kidrahahjo kidrahahjo commented Jul 30, 2020

Description

This enables storing aggregate information during submission and fetches the before status printing.
This is necessary to fetch information about the missing aggregates

Motivation and Context

This is to be merged into glotzerlab/signac-flow:enable-aggregate-submission after #1
After this gets merged, glotzerlab/signac-flow:enable-aggregate-submission will be ready to get merged into glotzerlab/signac-flow:master. After that, we'll now have to introduce the aggregator classes (glotzerlab#306) into glotzerlab/signac-flow:master.

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

If necessary:

  • I have updated the API documentation as part of the package doc-strings.
  • I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
  • I have updated the changelog.

@kidrahahjo kidrahahjo force-pushed the enable-aggregate-status-check branch from da157ba to 702ae4e Compare August 3, 2020 11:49
@kidrahahjo
Copy link
Owner Author

This is moved to glotzerlab#335

@kidrahahjo kidrahahjo closed this Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant