Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [KIECLOUD-273] Operator sdk v0.9.0 #216

Closed
wants to merge 5 commits into from

Conversation

xieshenzh
Copy link
Contributor

Update kie-cloud-operator for operator-sdk v0.9

@openshift-ci-robot
Copy link
Collaborator

Hi @xiezhang7. Thanks for your PR.

I'm waiting for a kiegroup or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiezhang7
To complete the pull request process, please assign tchughesiv
You can assign the PR to them by writing /assign @tchughesiv in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xieshenzh
Copy link
Contributor Author

Hi @bmozaffa , this pull request is for operator-sdk v0.9.x . I'll update the pull request once operator-sdk v0.9.0 is released. Thanks.

Copy link
Collaborator

@bmozaffa bmozaffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Xieshen. A few other requests:

  • Given the size, please separate out your PR into separate commits for vendor directory and other files. Squash the changes for upgrade to 0.8.1 vs 0.9, though this can wait if you think we might want to go with 0.8.1 at some point.
  • Create a jira assigned to yourself (example https://issues.jboss.org/browse/KIECLOUD-192) targeting 7.5.0 for this task, outlining SDK + Go + Mod upgrades.
  • Mark this PR with [KIECLOUD-XXXX] to point to the JIRA
  • Start PR title with [WIP] to prevent it from merging prematurely.

tools.go Show resolved Hide resolved
pkg/apis/app/v1/kieapp_types.go Outdated Show resolved Hide resolved
@xieshenzh xieshenzh changed the title Operator sdk v0.9.0 [WIP] [KIECLOUD-273] Operator sdk v0.9.0 Jul 8, 2019
@tchughesiv
Copy link
Member

/hold

@xieshenzh xieshenzh force-pushed the operator-sdk-v0.9.0 branch from 1c93b99 to 07a2acb Compare July 8, 2019 19:12
@xieshenzh
Copy link
Contributor Author

xieshenzh commented Jul 15, 2019

With operator-sdk v0.9.0, operator-sdk generate k8s doesn't work correctly using Go installation via dnf on Fedora. Follow the instructions and download the archive to install Go instead.

@openshift-ci-robot
Copy link
Collaborator

@xiezhang7: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants