-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [KIECLOUD-273] Operator sdk v0.9.0 #216
Conversation
Hi @xiezhang7. Thanks for your PR. I'm waiting for a kiegroup or openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xiezhang7 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @bmozaffa , this pull request is for operator-sdk v0.9.x . I'll update the pull request once operator-sdk v0.9.0 is released. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Xieshen. A few other requests:
- Given the size, please separate out your PR into separate commits for vendor directory and other files. Squash the changes for upgrade to 0.8.1 vs 0.9, though this can wait if you think we might want to go with 0.8.1 at some point.
- Create a jira assigned to yourself (example https://issues.jboss.org/browse/KIECLOUD-192) targeting 7.5.0 for this task, outlining SDK + Go + Mod upgrades.
- Mark this PR with [KIECLOUD-XXXX] to point to the JIRA
- Start PR title with [WIP] to prevent it from merging prematurely.
/hold |
1c93b99
to
07a2acb
Compare
With operator-sdk v0.9.0, |
@xiezhang7: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update kie-cloud-operator for operator-sdk v0.9