Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crd schema #406

Merged
merged 1 commit into from
Mar 30, 2020
Merged

fix crd schema #406

merged 1 commit into from
Mar 30, 2020

Conversation

tchughesiv
Copy link
Member

@tchughesiv tchughesiv commented Mar 27, 2020

fixes this error seen in ocp4.3.5 when crd is installed -

[spec.version[v2].schema.openAPIV3Schema.type: Required value: must not be empty at the root, spec.version[v1].schema.openAPIV3Schema.type: Required value: must not be empty at the root]

adds printer columns -

$ oc get kieapp
NAME          VERSION   ENVIRONMENT   STATUS     AGE
rhpam-trial   7.8.0     rhpam-trial   Deployed   5m5s
test          7.8.0     rhpam-trial   Deployed   3m55s

[WIP] allow oc explain to work as expected as well??
kubernetes/kube-openapi#97
https://itnext.io/understanding-kubectl-explain-9d703396cc8

Signed-off-by: tchughesiv [email protected]

Signed-off-by: tchughesiv <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tchughesiv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@bmozaffa bmozaffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tchughesiv tchughesiv changed the title [wip] fix crd schema fix crd schema Mar 30, 2020
@openshift-merge-robot openshift-merge-robot merged commit 6f885e8 into kiegroup:master Mar 30, 2020
@tchughesiv tchughesiv deleted the crdFix branch April 8, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants