Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Util classes to framework-cloud-common #97

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move Util classes to framework-cloud-common #97

wants to merge 1 commit into from

Conversation

MarianMacik
Copy link
Member

sutaakar
sutaakar approved these changes Nov 27, 2017
View reviewed changes
Copy link
Collaborator

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor suggestion.

...k-cloud/framework-cloud-common/src/main/java/org/kie/cloud/common/client/util/TimeUtils.java Outdated
@@ -13,7 +13,7 @@
* limitations under the License.
*/

package org.kie.cloud.integrationtests.util;
package org.kie.cloud.common.client.util;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion - TimeUtils could be moved to different package as it is used also outside of client util classes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to org.kie.cloud.common.time package. Took inspiration from org.kie.cloud.common.logs which contains InstanceLogUtil.

@MarianMacik
Copy link
Member Author

jenkins retest this

@jiripetrlik
Copy link
Contributor

@MarianMacik
Hello, I'm wondering about the date. I think we can probably close this one. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubschwan jakubschwan jakubschwan approved these changes

@sutaakar sutaakar sutaakar approved these changes

@jhrcek jhrcek jhrcek approved these changes

@jiripetrlik jiripetrlik Awaiting requested review from jiripetrlik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MarianMacik @jiripetrlik @jhrcek @sutaakar @jakubschwan