RHPAM-4970 locate pom with snapshot versioning on Springboot #277
Conversation
|
@elguardian related with JBPM-9829 |
|
@albfan why are your replacing timestamps ? |
|
Trying to identify any kjar installed from a maven repository. When it uses local maven repository, pom name contains SNAPSHOT, but from external maven repository pom has that pattern replaced with timestamp, pom is not located and InJar fails For an artifact named kjar-1.0.0-SNAPSHOT, this will create the pattern BOOT-INF/clases/KIE-INF/lib/kjar-1.0.0-SNAPSHOT.pom or BOOT-INF/clases/KIE-INF/lib/kjar-1.0.0-20240717-173300-1.pom Covering usage of external maven repositories on build pipelines |
|
effectivePom only look for files ending in "pom". I tested and it's working for BOOT-INF/clases/KIE-INF/lib/kjar-1.0.0-SNAPSHOT.pom or BOOT-INF/clases/KIE-INF/lib/kjar-1.0.0-20240717-173300-1.pom |
|
Added an initial test for both scenarios (artifact retrieved from local repository and external repository) Refactoring Resolvers it might be possible to Mock them instead |
...up-maven-integration/src/test/java/org/appformer/maven/integration/ArtifactResolverTest.java
Outdated
Show resolved
Hide resolved
|
ok to test |
...integration/src/main/java/org/appformer/maven/integration/AbstractFilesArtifactResolver.java
Outdated
Show resolved
Hide resolved
...integration/src/main/java/org/appformer/maven/integration/AbstractFilesArtifactResolver.java
Outdated
Show resolved
Hide resolved
albfan
force-pushed
the
RHPAM-4970
branch
2 times, most recently
from
0b1dcb8 to
ee35707
Compare
|
Should I remove the test? Feedback from reporter is positive, can this change be merged? |
|
jenkins run fdb |
fjtirado
added
backport-7.67.x
albfan
force-pushed
the
RHPAM-4970
branch
3 times, most recently
from
c9c01a0 to
3bc0cb5
Compare
|
jenkins run fdb |
|
jenkins do fdb |
2 similar comments
|
jenkins do fdb |
|
jenkins do fdb |
|
jenkins run fdb |
* prepare classes for testing * locate pom with snapshot --------- Co-authored-by: Alberto Fanjul <[email protected]>
* prepare classes for testing * locate pom with snapshot --------- Co-authored-by: Alberto Fanjul <[email protected]>
Ignore timestamped SNAPSHOT replacements to find and parse pom artifact
JIRA: https://issues.redhat.com/browse/RHPAM-4970