Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running FreeHEPSVGOffscreenRenderingTest runs into wrong failures #132

Closed
NiklasRentzCAU opened this issue Jul 12, 2022 · 0 comments
Closed

Comments

@NiklasRentzCAU
Copy link
Member

The FreeHEPSVGOffscreenRenderingTest checks for String equivalence of the generated SVG, when running them locally on a Linux machine with Java 11 causes the SVGs to be equivalent, but with differently ordered attributes, causing the tests to fail. This is one of the failures as written to the console:

FreeHEPSVGOffscreenRenderingTest.test14c_singleKNodeWithEastPortWithSemanticData_And_WithOutsideLabelWithSemanticData_And_MultiLineTextWithSemanticData:1102->equalsSVGof:1106->equalsSVGof:1126 expected:
<<g stroke-[linejoin="miter" stroke-dashoffset="0" stroke-dasharray="none" stroke-width="1" stroke-miterlimit="10" stroke-linecap="butt">
<g fill="none" stroke-opacity="1" stroke="#000000">
  <path d="M 0.5 0.5 L 99.5 0.5 L 99.5 99.5 L 0.5 99.5 L 0.5 0.5 z"/>
</g>
<g id="MyPort" class="MyPortClass" klighd:MyKey="MyValue" klighd:My2ndKey="KPort:0">
<g transform="matrix(1, 0, 0, 1, 100, 47.5)">
<g fill="none" stroke-opacity="1" stroke="#000000">
  <path d="M 0.5 0.5 L 4.5 0.5 L 4.5 4.5 L 0.5 4.5 L 0.5 0.5 z"/>
</g>
</g>
<g id="MyLabel" class="MyLabelClass" klighd:MyKey="MyValue" klighd:My2ndKey="KLabel:0">
<g transform="matrix(1, 0, 0, 1, 106, 45)" fill-opacity="1" font-style="normal" font-family="Helvetica" font-weight="normal" stroke="none" fill="#000000" font-size="<FONT_SIZE>]" id="MyText" class=...>

but was:
<<g stroke-[dashoffset="0" stroke-linejoin="miter" stroke-dasharray="none" stroke-width="1" stroke-linecap="butt" stroke-miterlimit="10">
<g stroke-opacity="1" fill="none" stroke="#000000">
  <path d="M 0.5 0.5 L 99.5 0.5 L 99.5 99.5 L 0.5 99.5 L 0.5 0.5 z"/>
</g>
<g id="MyPort" class="MyPortClass" klighd:MyKey="MyValue" klighd:My2ndKey="KPort:0">
<g transform="matrix(1, 0, 0, 1, 100, 47.5)">
<g stroke-opacity="1" fill="none" stroke="#000000">
  <path d="M 0.5 0.5 L 4.5 0.5 L 4.5 4.5 L 0.5 4.5 L 0.5 0.5 z"/>
</g>
</g>
<g id="MyLabel" class="MyLabelClass" klighd:MyKey="MyValue" klighd:My2ndKey="KLabel:0">
<g transform="matrix(1, 0, 0, 1, 106, 45)" font-weight="normal" font-size="<FONT_SIZE>" font-family="Helvetica" font-style="normal" fill="#000000" fill-opacity="1" stroke="none]" id="MyText" class=...>

The tests should ignore such attribute re-orderings and still succeed in that case and not only work later when executed on GitHub Actions.

sailingKieler added a commit that referenced this issue Dec 22, 2022
…tionTest' to pass on linux again (font size diffs :-/ ), made 'FreeHEPSVGOffscreenRenderingTest' more robust wrt. non-determinisms caused by hash maps and the like, fixes #132
sailingKieler added a commit that referenced this issue Dec 22, 2022
…tionTest' to pass on linux again (font size diffs :-/ ), made 'FreeHEPSVGOffscreenRenderingTest' more robust wrt. non-determinisms caused by hash maps and the like, fixes #132
sailingKieler added a commit that referenced this issue Jan 2, 2023
…tionTest' to pass on linux again (font size diffs :-/ ), made 'FreeHEPSVGOffscreenRenderingTest' more robust wrt. non-determinisms caused by hash maps and the like, fixes #132

 * dropped dependency to Xbase from 'kieler.kgraph.text' & '.ide', added JDT-free binding of 'IAllContainersState' in KGraphUiModule in 'kieler.kgraph.text.ui'
sailingKieler added a commit that referenced this issue Jan 5, 2023
…tionTest' to pass on linux again (font size diffs :-/ ), made 'FreeHEPSVGOffscreenRenderingTest' more robust wrt. non-determinisms caused by hash maps and the like, fixes #132

 * dropped dependency to Xbase from 'kieler.kgraph.text' & '.ide', added JDT-free binding of 'IAllContainersState' in KGraphUiModule in 'kieler.kgraph.text.ui'
sailingKieler added a commit that referenced this issue Jan 5, 2023
…tionTest' to pass on linux again (font size diffs :-/ ), made 'FreeHEPSVGOffscreenRenderingTest' more robust wrt. non-determinisms caused by hash maps and the like, fixes #132

 * dropped dependency to Xbase from 'kieler.kgraph.text' & '.ide', added JDT-free binding of 'IAllContainersState' in KGraphUiModule in 'kieler.kgraph.text.ui'
sailingKieler added a commit that referenced this issue Jan 5, 2023
…tionTest' to pass on linux again (font size diffs :-/ ), made 'FreeHEPSVGOffscreenRenderingTest' more robust wrt. non-determinisms caused by hash maps and the like, fixes #132

 * dropped dependency to Xbase from 'kieler.kgraph.text' & '.ide', added JDT-free binding of 'IAllContainersState' in KGraphUiModule in 'kieler.kgraph.text.ui'
sailingKieler added a commit that referenced this issue Jan 9, 2023
…tionTest' to pass on linux again (font size diffs :-/ ), made 'FreeHEPSVGOffscreenRenderingTest' more robust wrt. non-determinisms caused by hash maps and the like, fixes #132

 * dropped dependency to Xbase from 'kieler.kgraph.text' & '.ide', added JDT-free binding of 'IAllContainersState' in KGraphUiModule in 'kieler.kgraph.text.ui'
sailingKieler added a commit that referenced this issue Jan 9, 2023
…tionTest' to pass on linux again (font size diffs :-/ ), made 'FreeHEPSVGOffscreenRenderingTest' more robust wrt. non-determinisms caused by hash maps and the like, fixes #132

 * dropped dependency to Xbase from 'kieler.kgraph.text' & '.ide', added JDT-free binding of 'IAllContainersState' in KGraphUiModule in 'kieler.kgraph.text.ui'
sailingKieler added a commit that referenced this issue Jan 9, 2023
…tionTest' to pass on linux again (font size diffs :-/ ), made 'FreeHEPSVGOffscreenRenderingTest' more robust wrt. non-determinisms caused by hash maps and the like, fixes #132

 * dropped dependency to Xbase from 'kieler.kgraph.text' & '.ide', added JDT-free binding of 'IAllContainersState' in KGraphUiModule in 'kieler.kgraph.text.ui'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant