Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some interfaces/classes are too Eclipse/SWT-specific #63

Closed
NiklasRentzCAU opened this issue Jul 31, 2020 · 0 comments · Fixed by #162
Closed

Some interfaces/classes are too Eclipse/SWT-specific #63

NiklasRentzCAU opened this issue Jul 31, 2020 · 0 comments · Fixed by #162
Assignees
Labels
enhancement New feature or request

Comments

@NiklasRentzCAU
Copy link
Member

Some interfaces/classes such as IViewer, ContextViewer, and many more have dependencies to eclipse.ui and eclipse.swt and therefore require those dependencies even for a Eclipse-less application such as the language server. With that they also require somewhat odd implementations to work around those dependencies (see SprottyViewer in klighd.lsp for example).
For a cleaner separation between Eclipse usage and non-Eclipse usage, these interfaces need to be reworked and the dependencies to be removed for a default use case.

This ticket probably requires to rework a lot of the core functionality and is therefore only here for documentation purposes as a nice-to-have and as a reference for why some implementations in klighd.lsp have to look as they do currently.

@NiklasRentzCAU NiklasRentzCAU added the enhancement New feature or request label Jul 31, 2020
NiklasRentzCAU added a commit that referenced this issue Jul 29, 2022
…n dependencies. Depend on SWT mock code for the language server to allow for platform-independent LS.

Fixes #63
@NiklasRentzCAU NiklasRentzCAU self-assigned this May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant