Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused tooltip field from skgraph field and corresponding references #115

Merged
merged 1 commit into from
May 16, 2022
Merged

remove unused tooltip field from skgraph field and corresponding references #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .../de.cau.cs.kieler.klighd.lsp/src/de/cau/cs/kieler/klighd/lsp/KGraphDiagramGenerator.xtend
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,6 @@ class KGraphDiagramGenerator implements IDiagramGenerator {
val nodeElement = configSElement(SKNode, idGen.getId(node))

nodeElement.size = new Dimension(node.width, node.height)
nodeElement.tooltip = node.getProperty(KlighdProperties.TOOLTIP)
val filteredData = node.data.filter [
KRendering.isAssignableFrom(it.class) || KRenderingLibrary.isAssignableFrom(it.class)
].toList
Expand Down Expand Up @@ -311,7 +310,6 @@ class KGraphDiagramGenerator implements IDiagramGenerator {
val SKEdge edgeElement = configSElement(SKEdge, idGen.getId(edge))
edgeElement.sourceId = idGen.getId(edge.source)
edgeElement.targetId = idGen.getId(edge.target)
edgeElement.tooltip = edge.getProperty(KlighdProperties.TOOLTIP)

val renderings = edge.data.filter[KRendering.isAssignableFrom(it.class)].toList

Expand All @@ -333,7 +331,6 @@ class KGraphDiagramGenerator implements IDiagramGenerator {
*/
protected def SKPort generatePort(KPort port) {
val SKPort portElement = configSElement(SKPort, idGen.getId(port))
portElement.tooltip = port.getProperty(KlighdProperties.TOOLTIP)

val renderings = port.data.filter [ KRendering.isAssignableFrom(it.class)].toList

Expand All @@ -354,7 +351,6 @@ class KGraphDiagramGenerator implements IDiagramGenerator {
*/
protected def SKLabel generateLabel(KLabel label) {
val SKLabel labelElement = configSElement(SKLabel, idGen.getId(label))
labelElement.tooltip = label.getProperty(KlighdProperties.TOOLTIP)
labelElement.text = label.text

val renderings = label.data.filter[KRendering.isAssignableFrom(it.class)].toList
Expand Down
1 change: 0 additions & 1 deletion ...kieler.klighd.lsp/src/de/cau/cs/kieler/klighd/lsp/KGraphIncrementalDiagramGenerator.xtend
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,6 @@ class KGraphIncrementalDiagramGenerator extends KGraphDiagramGenerator {
val nodeElement = configSElement(SKNode, idGen.getId(node))

nodeElement.size = new Dimension(node.width, node.height)
nodeElement.tooltip = node.getProperty(KlighdProperties.TOOLTIP)
val filteredData = node.data.filter [
KRendering.isAssignableFrom(it.class) || KRenderingLibrary.isAssignableFrom(it.class)
].toList
Expand Down
4 changes: 0 additions & 4 deletions plugins/de.cau.cs.kieler.klighd.lsp/src/de/cau/cs/kieler/klighd/lsp/model/KGraphModel.xtend
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ class SKNode extends SNode implements SKElement {
List<KGraphData> data
HashMap<String, Object> properties = newHashMap
Direction direction
String tooltip
}

/**
Expand All @@ -64,7 +63,6 @@ class SKNode extends SNode implements SKElement {
@Accessors
class SKLabel extends SLabel implements SKElement {
List<KGraphData> data
String tooltip
HashMap<String, Object> properties = newHashMap
}

Expand All @@ -77,7 +75,6 @@ class SKLabel extends SLabel implements SKElement {
@Accessors
class SKEdge extends SEdge implements SKElement {
List<KGraphData> data
String tooltip
KVectorChain junctionPoints
HashMap<String, Object> properties = newHashMap
}
Expand All @@ -91,7 +88,6 @@ class SKEdge extends SEdge implements SKElement {
@Accessors
class SKPort extends SPort implements SKElement {
List<KGraphData> data
String tooltip
HashMap<String, Object> properties = newHashMap
}

Expand Down