Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Language Server more robust against problems with SWT #117

Merged
merged 2 commits into from
May 31, 2022

Conversation

NiklasRentzCAU
Copy link
Member

This fixes two issues that were present when executing the Language Server on a system which has problems with calling SWT, for example on new Macs with M2 chips:

  • removes the SWT image from being sent to klighd-vscode clients, where it was ignored anyways
  • introcudes a try-catch in the text size estimation switch between STW and AWT, where the SWT check could throw and not fall back on AWT metrics instead.

This allows e.g. the language server to do its size estimation even if
something with the SWT configuration is off, such as is the case for
some MacOS devices.
Avoids potential to send a not used reference of an SWT image, which may
cause issues on serialization on MacOS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant