Mka/whitelist external properties #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eddykasp
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes which properties are kept for the serialization by default.
Now only klighd and elk properties are included by default. Any additionally desired properties must be registered on a whitelist through the KlighdDataManager. This prevents blind inclusion of properties which might be incompatible and requires users to be more explicit about their own properties that they may wish to include.
The blacklist can be used to forbid any property. This makes the most sense for forbidding properties that are included by default ("de.cau.cs.kieler.klighd*", "klighd*" or "org.eclipse.elk*"). External properties (with other prefixes) are now excluded by default. Adding them to the whitelist explicitly allows them to be added again. The whitelist is checked after the blacklist