Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrote a util for parsing semantic filter rules #141

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Wrote a util for parsing semantic filter rules #141

merged 1 commit into from
Aug 31, 2022

Conversation

fight4day
Copy link
Contributor

Implemented static parse() and tryParse(), the latter returns null instead of throwing an exception if the syntax is invalid.
Variants with rule names are supported as well.

@fight4day fight4day requested a review from Eddykasp August 29, 2022 14:24
@fight4day fight4day changed the title Wrote a util for parsing Wrote a util for parsing semantic filter rules Aug 29, 2022
Eddykasp
Eddykasp approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@Eddykasp Eddykasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Eddykasp Eddykasp merged commit 6c710e7 into mka/semantic-filtering-v2 Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eddykasp Eddykasp Eddykasp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fight4day @Eddykasp