Cap some Maven dependencies to Eclipse to avoid transitive Java17 requirements. #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the KLighD build broke down due to Maven dependencies of some Eclipse Plugins now requiring Java17. Eclipse did not up the major versions of their bundles, thus causing newer builds to pull bundles from newer Eclipse releases requiring Java17 and therefore breaking the build process. This is a workaround by fixing all problematic bundles to the exact version as provided in the accompanying P2 update site of the 2022-09 release to keep the build working.
For the future we probably should think about using Java17 in the automatic build, potentially still pinning the source code compatibility to Java1.8 to allow legacy projects building on Java1.8 to use the KLighD releases. That would allow to remove this workaround again and allow to update to newer Eclipse updates, which all force Java17 anyways since the 2022-09 update (see here).