Changed SVG generation of KTexts #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion to enable the generation of 'textLength' property values for '<text>' elements in SVGs (#44) * added flag in 'KlighdPaintContext', * added checkbox in 'SaveAsImageDiaglog' and related export data records * moved some recently misplaced properties from 'SVGOffscreenRenderer' to 'IOffscreenRenderer'
…nRenderingTest' * extracted logic for reveal test size data of KTexts in 'PlacementUtil' * included incorporation of test size data in 'KlighdStyledText' * switched to order preserving map impls in 'KlighdSemanticDiagramData' * refined 'SemanticSVGGraphics2D' here and there, dropped clipping around <text> elements
…SVG exporter to generate multi-line texts as a group of <text> elements instead of <tspan> elements (#44) * abolished generation of '<tspan>' elements entirely * updated 'FreeHEPSVGOffscreenRenderingTest'
|
See also #44 |
|
Generally looks good and now similar to the result that the Klighd-Sprotty view generates. There are still two minor problems I found:
|
|
@NiklasRentzCAU and @uruuru thanks for the feedback, I'll take care about it on occasion. |
…ents in changes for #44 as suggested by reviewers
sailingKieler
force-pushed
the
cs-44svgRefac
branch
from
fc8a1bf to
00a2ea3
Compare
|
Reported issues should be fixed now. |
NiklasRentzCAU
approved these changes
Aug 4, 2020
|
@NiklasRentzCAU or @soerendomroes please merge these changes before preparing the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, please test the SVG generation with your applications, if possible, and let me know if you see any problems.