Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default status handling to 'log', and show exceptions during synthesis transformations to the user. #76

Merged
merged 3 commits into from
Nov 10, 2020

Conversation

NiklasRentzCAU
Copy link
Member

Previously, any code calling Klighd.handle(IStatus) caused the status and possible warnings and exceptions within to not be shown anywhere. This alters that behavior, so that the status is at least logged, matching the default behavior of the previoulsy used Eclipse StatusManager's handle(IStatus) method.

Furthermore, this shows an exception being thrown during a synthesis to the user in addition to logging it, so that errors during syntheses can be tracked down more easily.

Copy link
Member

@sailingKieler sailingKieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NiklasRentzCAU,
a general question at first: Is the motivation of this change to change the behavior in Eclipse, or in the language server context?

I disagree with this change as productive application would have to spend effort to explicitly suppress this behavior (by trying to inject some wrapping status manager impl).
In dev environments this could easily been done in order to achieve the desired verbosity.

I agree with this change as it follows the behavior of org.eclipse.ui.statushandlers.StatusManager.

@NiklasRentzCAU
Copy link
Member Author

This is for the behavior in the Eclipse context. I can see though that a default verbosity to show the message in a popup might not be what is wanted in general. I'll revert that back and just keep the other change, so that it at least can be viewed in the error log.

@sailingKieler
Copy link
Member

Please squash the commits, and I'll be fine with them.

@NiklasRentzCAU NiklasRentzCAU merged commit 7f996bf into master Nov 10, 2020
@NiklasRentzCAU NiklasRentzCAU deleted the nre/showSynthesisException branch November 12, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants