Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWT Font Size Handling in Offscreen Redering #81

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

a-sr
Copy link
Member

@a-sr a-sr commented May 1, 2021

Added global switch to activate scaling factor AWT fonts to match SWT sizes.
Also adjusted svg renderer to use pixel sizes in offscreen mode.

Also adjusted svg renderer to use pixel sizes in offscreen mode.
@a-sr a-sr requested a review from NiklasRentzCAU May 1, 2021 09:07
@NiklasRentzCAU
Copy link
Member

Looks fine to me and non-affecting for any Eclipse use cases.
@sailingKieler Do you know of any use cases using the previous AWT text size estimations or SVG renderings that may be affected now? I don't know of any and would just merge this if you do not know of possible problems. If there might be some, this PR can be changed to disable the new feature by default and then turn it on where needed.

Copy link
Member

@NiklasRentzCAU NiklasRentzCAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NiklasRentzCAU NiklasRentzCAU merged commit abb01b0 into master Jun 2, 2021
@NiklasRentzCAU NiklasRentzCAU deleted the offscreen-fonts branch June 2, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants