Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused tooltip field #76

Merged
merged 1 commit into from
May 16, 2022
Merged

remove unused tooltip field #76

merged 1 commit into from
May 16, 2022

Conversation

Eddykasp
Copy link
Contributor

@Eddykasp Eddykasp commented May 3, 2022 •
edited
Loading

Resolves #73

The tooltip is already stored in the properties, this PR removes the unused tooltip fields.

Server-side PR

@Eddykasp Eddykasp mentioned this pull request May 3, 2022
Merged
@Eddykasp Eddykasp requested a review from NiklasRentzCAU May 3, 2022 08:46
NiklasRentzCAU
NiklasRentzCAU approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@NiklasRentzCAU NiklasRentzCAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the tooltips already worked with the new system with the properties and this field was now unused? I thought this would require more changes to make tooltips work in the new system again. But if that is not the case and no more changes are needed, LGTM.

@Eddykasp Eddykasp merged commit d3bef93 into main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasRentzCAU NiklasRentzCAU NiklasRentzCAU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Put Tooltip back into the property field
2 participants
@Eddykasp @NiklasRentzCAU