Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Honeywell sensor type for Generic #16

Closed
hpsaturn opened this issue Nov 3, 2020 · 0 comments
Closed

Change Honeywell sensor type for Generic #16

hpsaturn opened this issue Nov 3, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@hpsaturn
Copy link
Member

hpsaturn commented Nov 3, 2020

Summary.

For compatibility with the Android app and also because Honeywell, Plantower and Panasonic run in the same auto-detection flow, we should change the first enum option Honeywell to Generic like is on Android app
@hpsaturn hpsaturn added the enhancement New feature or request label Nov 3, 2020
hpsaturn added a commit that referenced this issue Nov 8, 2020
@hpsaturn
refactor sensor typem enum for issue #16
e998729
@hpsaturn hpsaturn mentioned this issue Nov 8, 2020
Merged
hpsaturn added a commit that referenced this issue Nov 8, 2020
@hpsaturn
Merge pull request #20 from kike-canaries/refactor_enum_generic_#16
d48e6c0 
Refactor enum generic #16
@hpsaturn hpsaturn closed this as completed Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hpsaturn