Don't multiply the measurement interval by 2 for SCD30 #110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: This modification only affects Sensirion's SCD30 sensor.
When modifying measurement interval (by calling method void Sensors::setSampleTime(int seconds)), library multiplied time by 2 in an intent to reduce power consumption.
Now it 's modified so what is does coincide with function name.
This optimization to reduce power consumption., if needed , should be done by function caller as, for example:
Change:
sensors.setSampleTime(seconds)
To:
Related Issues
Warning: SCD30 sensors should be calibrated again after modifying measurement interval, so you should do it or modify the function caller at the same time you upgrade the library.
Tests