Moving sum feature

[hpsaturn]

Description

• Please enter a description :D
• tested only on compiling time, 3 of 4 tests ok.

[hpsaturn]

Hi guys, I tried to organize and do the pull request that did @iw2lsi, but I don't know maybe I did some mistake. Please @iw2lsi review the PR here in the tab "files changed". And please @roberbike try to check it, because I can't help you because I haven't the hardware. I did the PR and run the tests on the root and pass 3 of 4 tests, ESP8266 fails, but you guys should be know more.

[iw2lsi]

it seems fine to me... I have some doubts regarding src/Sensors.hpp and in particular on:

lines 132:

X(CPM, "CPM", "CPM")       \
X(RADIATION, "uSv/h", "Radiation") \
X(UCOUNT, "COUNT", "UCOUNT")

line 157:
X(SCAJOE, "CAJOE", 4)
X(SCOUNT, "SCOUNT", 3)

line 169:
SENSOR_ENV,
SENSOR_RAD // CAJOE_GEIGER
};

lately I'll like to change:

cajoe_fms = new MovingSum<uint16_t, uint32_t>(GEIGER_BUFSIZE);

to:

cajoe_fms = new MovingSum<uint8_t, uint16_t>(GEIGER_BUFSIZE);

and check the related variable everywhere...

BTW: you do not neet a sensor... you can just use a switch or a wire between pin 26 and GND/+3v3... you'll get some bounces but that's not a problem...

The changes in the iw2lsi/canairio_firmware@dd80980 are really few lines regarding HASS publishing.

[hpsaturn]

@iw2lsi you can push new changes to this branch moving_sum_feature in your fork, and with that the PR here will update.

[roberbike]

Tested on esp32 with tft.
uSvh only show 0000 values. It need 2 decimals almost. By serial the data is ok.
Esp 8266 is not compatible with hardware timer: hw_timer_t* geiger_timer = NULL

[iw2lsi]

Hi

uSvh only show 0000 values. It need 2 decimals almost.

you are right... I did not test the tft at all... I was only focused on serial data and mqtt publishing

Esp 8266 is not compatible with hardware timer: hw_timer_t* geiger_timer

= NULL is there a software timer we can use on 8266 ? maybe we can "relax" the ist and trigger it every 1s instead of 250ms (and use 60 samples instead of 240) Il giorno mer 8 giu 2022 alle ore 14:50 roberbike ***@***.***> ha scritto:

…

***@***.**** commented on this pull request. Tested on esp32 with tft. uSvh only show 0000 values. It need 2 decimals almost. Esp 8266 is not compatible with hardware timer: hw_timer_t* geiger_timer = NULL — Reply to this email directly, view it on GitHub <#139 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAODQQDXWUHUMFPIYOHVMJDVOCJJ5ANCNFSM5YF4M5FA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[hpsaturn]

@roberbike when you have some time, please check this PR. If you think that it is ok, I will merge it to geiger_version branch

[iw2lsi]

ok... I'll try that... as I told you, I have a very-basic experience w/ github. As I'm at work now, I'll do that this evening or tomorrow. Giampaolo Il giorno mer 8 giu 2022 alle ore 12:11 Antonio Vanegas < ***@***.***> ha scritto:

…

@iw2lsi <https://github.com/iw2lsi> you can push new changes to this branch moving_sum_feature in your fork, and with that the PR here will update. — Reply to this email directly, view it on GitHub <#139 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAODQQG234KRSSHVBKU4EOLVOBWULANCNFSM5YF4M5FA> . You are receiving this because you were mentioned.Message ID: ***@***.***>