Nh3 support #167
Merged
Nh3 support #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpsaturn
approved these changes
Jun 10, 2023
| @@ -977,21 +988,53 @@ void Sensors::GCJA5Read() { | |||
|
|
|||
|
|
|||
| void Sensors::DFRobotGravityRead() { | |||
| String gastype = dfr_gas.queryGasType(); | |||
|
|
|||
| DFRobot_GAS_I2C dfr_co(&Wire,0x74); { | |||
There was a problem hiding this comment.
Esa linea deberia ser parte del init no del read.
| * gas.OFF：turn off | ||
| */ | ||
| gas.setTempCompensation(gas.ON); | ||
| DFRobot_GAS_I2C dfr_nh3(&Wire,0x77); |
There was a problem hiding this comment.
dfr_nh3 debe ser global, aqui esta siendo local, y por ello, al no ser global el read fallaria.
hpsaturn
reviewed
Jun 10, 2023
| @@ -213,8 +213,9 @@ class Sensors { | |||
| PM1006 *pm1006; | |||
|
|
|||
| // DFRobot gravity Gas sensor | |||
| DFRobot_GAS_I2C dfr_gas; | |||
|
|
|||
| //DFRobot_GAS_I2C dfr_gas; | |||
There was a problem hiding this comment.
es el mismo objeto, no necesitamos dos, con uno basta. Debemos es usar los llamados especificos para unidad, para asi tener las dos unidades
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Falla la lectura de los sensores NH3 y CO.