Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HAL-05] feat: add fees validation at initialization #52

Merged
merged 3 commits into from
Aug 25, 2022

Conversation

0xpanoramix
Copy link
Contributor

@0xpanoramix 0xpanoramix commented Aug 9, 2022

Description

When the contract is initialized, we now check if the fees are greater then 10000 and revert if true.
It closes #51.

@0xpanoramix 0xpanoramix requested a review from mortimr August 9, 2022 00:56
@0xpanoramix 0xpanoramix marked this pull request as draft August 9, 2022 00:56
@0xpanoramix 0xpanoramix marked this pull request as ready for review August 9, 2022 01:03
@0xpanoramix 0xpanoramix requested a review from nmvalera August 9, 2022 16:37
@0xpanoramix 0xpanoramix self-assigned this Aug 10, 2022
Copy link
Contributor

@nmvalera nmvalera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mortimr mortimr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xpanoramix 0xpanoramix changed the title feat: add fees validation at initialization [HAL-05] feat: add fees validation at initialization Aug 10, 2022
@mortimr mortimr force-pushed the feat/validate-fees-at-initialization branch from c00b51b to 4e8242a Compare August 25, 2022 15:09
@mortimr mortimr merged commit 6dc293a into master Aug 25, 2022
@mortimr mortimr deleted the feat/validate-fees-at-initialization branch August 25, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate fees in initialize_1 method
3 participants