Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HAL-04] feat: support transfer ownership #54

Merged
merged 5 commits into from
Aug 25, 2022

Conversation

0xpanoramix
Copy link
Contributor

Description

The ownership transfer now implies that the new admin must accept his new role by calling the acceptAdmin method.
Here is the new flow:

  1. SC deployment: admin and newAdmin are set to admin.
  2. When setAdmin is called: admin initiate transfer to newAdmin.
  3. newAdmin must call acceptAdmin. He is the only one able to call this method without being unauthorized.

Signed-off-by: Luca Georges Francois <[email protected]>
@0xpanoramix 0xpanoramix self-assigned this Aug 11, 2022
Signed-off-by: Luca Georges Francois <[email protected]>
Signed-off-by: Luca Georges Francois <[email protected]>
Signed-off-by: Luca Georges Francois <[email protected]>
Copy link
Contributor

@mortimr mortimr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mortimr mortimr merged commit 09e3863 into master Aug 25, 2022
@mortimr mortimr deleted the feat/add-ownership-transfer branch August 25, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants