Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(6): execution layer fee recipients #9

Merged
merged 7 commits into from
Jun 13, 2022
Merged

feat(6): execution layer fee recipients #9

merged 7 commits into from
Jun 13, 2022

Conversation

mortimr
Copy link
Contributor

@mortimr mortimr commented Jun 2, 2022

Resolves #6

@mortimr mortimr marked this pull request as ready for review June 3, 2022 15:07
0xpanoramix
0xpanoramix requested changes Jun 4, 2022
View reviewed changes
src/contracts/StakingContract.sol Outdated Show resolved Hide resolved
src/contracts/StakingContract.sol Outdated Show resolved Hide resolved
nmvalera
nmvalera suggested changes Jun 5, 2022
View reviewed changes
Copy link
Contributor

@nmvalera nmvalera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally great implementation. Good to us openzeppelin Clones.

Most of my review is minor comments.

src/contracts/interfaces/IFeeRecipient.sol Show resolved Hide resolved
src/contracts/libs/FeeRecipientStateLib.sol Outdated Show resolved Hide resolved
src/contracts/libs/StakingContractStateLib.sol Outdated Show resolved Hide resolved
src/contracts/ConsensusLayerFeeRecipient.sol Outdated Show resolved Hide resolved
src/contracts/ConsensusLayerFeeRecipient.sol Show resolved Hide resolved
src/contracts/StakingContract.sol Outdated Show resolved Hide resolved
src/contracts/StakingContract.sol Outdated Show resolved Hide resolved
src/contracts/StakingContract.sol Show resolved Hide resolved
src/contracts/StakingContract.sol Outdated Show resolved Hide resolved
src/contracts/StakingContract.sol Outdated Show resolved Hide resolved
@mortimr mortimr force-pushed the feat/6/execution-layer-fee-recipients branch from 0f5bc93 to f9ddb98 Compare June 7, 2022 14:56
@mortimr mortimr force-pushed the feat/6/execution-layer-fee-recipients branch from cbc4df7 to c496fc2 Compare June 9, 2022 11:28
@mortimr mortimr force-pushed the feat/6/execution-layer-fee-recipients branch 2 times, most recently from 01a4eaf to 15d0147 Compare June 10, 2022 17:31
@mortimr mortimr force-pushed the feat/6/execution-layer-fee-recipients branch from 15d0147 to c03549c Compare June 10, 2022 18:21
nmvalera
nmvalera suggested changes Jun 13, 2022
View reviewed changes
src/contracts/StakingContract.sol Outdated Show resolved Hide resolved
src/contracts/libs/State.sol Outdated Show resolved Hide resolved
nmvalera
nmvalera approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@nmvalera nmvalera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mortimr mortimr merged commit a0ac14c into master Jun 13, 2022
@mortimr mortimr deleted the feat/6/execution-layer-fee-recipients branch June 13, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmvalera nmvalera nmvalera approved these changes

@loicttn loicttn Awaiting requested review from loicttn

@aimxhaisse aimxhaisse Awaiting requested review from aimxhaisse

@VrncQuentin VrncQuentin Awaiting requested review from VrncQuentin

@0xpanoramix 0xpanoramix Awaiting requested review from 0xpanoramix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Execution layer fees collection
4 participants
@mortimr @nmvalera @VrncQuentin @0xpanoramix