Remove validateURL checks #13
Conversation
remove regex check for url
|
Warning Rate Limit Exceeded@viv-kinde has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 52 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent update to the KindeClientSDK simplifies the process of initializing the SDK by removing the URL validation checks for key parameters such as Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| if (domain == null || domain.isEmpty()) { | ||
| throw new IllegalArgumentException("Please provide domain"); | ||
| } | ||
| if (!Utils.validateURL(domain)) { | ||
| throw new IllegalArgumentException("Please provide valid domain"); | ||
| } | ||
| this.domain = domain; | ||
|
|
||
| if (redirectUri == null || redirectUri.isEmpty()) { | ||
| throw new IllegalArgumentException("Please provide redirect_uri"); | ||
| } | ||
| if (!Utils.validateURL(redirectUri)) { | ||
| throw new IllegalArgumentException("Please provide valid redirect_uri"); | ||
| } | ||
| this.redirectUri = redirectUri; | ||
|
|
||
| if (clientSecret == null || clientSecret.isEmpty()) { |
There was a problem hiding this comment.
📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [103-105]
Consider adding basic URL format validation for domain, redirectUri, and logoutRedirectUri parameters to ensure they are well-formed URLs.
+ import java.net.URL;
+
if (domain == null || domain.isEmpty()) {
throw new IllegalArgumentException("Please provide domain");
}
+ try {
+ new URL(domain);
+ } catch (MalformedURLException e) {
+ throw new IllegalArgumentException("Domain must be a valid URL");
+ }Repeat similar validation for redirectUri and logoutRedirectUri. This ensures that the URLs are syntactically valid, reducing the risk of errors or security vulnerabilities associated with malformed URLs.
remove regex check
Update UtilsTest.java
There was a problem hiding this comment.
Looks fine, removal of URL Check.
That was one crazy regex, going to assume this was a nice to have. There's a library that's in the JDK that does this we could use: https://developer.classpath.org/doc/java/net/URL.html
|
With the updated version of the SDK this change has now been made redundant please close. |
|
This is no longer a requirement with the new SDK. Please close this PR. |
remove regex check for url
Explain your changes
Suppose there is a related issue with enough detail for a reviewer to understand your changes fully. In that case, you can omit an explanation and instead include either “Fixes #XX” or “Updates #XX” where “XX” is the issue number.
Checklist
🛟 If you need help, consider asking for advice over in the Kinde community.
Summary by CodeRabbit