Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the line and column numbering in the text viewer #76

Closed
geoffroy-noel-ddh opened this issue Sep 25, 2024 · 3 comments
Closed

Improve the line and column numbering in the text viewer #76

geoffroy-noel-ddh opened this issue Sep 25, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@geoffroy-noel-ddh
Copy link
Member

Inscriptions 827 & 613 have column breaks.

Which should appear as column label in the text display.

Additionally the display of line labels should better follow the label in the n attribute.
Some special cases:

n=0: for a line at the beginning or end of a section (e.g. column) which is not transcribed (e.g. not legible, damaged or missing).

n=13a: for a line at the end of a section.

These are epidoc conventions.

@geoffroy-noel-ddh geoffroy-noel-ddh self-assigned this Sep 25, 2024
@simonastoyanova
Copy link
Collaborator

Inscription 1040 has texpart divs <div type="textpart" subtype="fragment-physical" n="a"> and @n="b". In each textpart div the lbs are numbered from 1 onwards.

For comparison, 1485 has texpart divs (different subtype value but also numbered a, b, c, etc.) which have sequential numbers on the lbs; these are displayed with a blank line between the textpart divs which works very well.

Inscription 2945 has a lb n=0.

Inscription 4407 has cbs.

@geoffroy-noel-ddh
Copy link
Member Author

Hi @simonastoyanova , this should be fixed now. You can close if you are happy with resolution.

@geoffroy-noel-ddh geoffroy-noel-ddh added the bug Something isn't working label Sep 27, 2024
@simonastoyanova
Copy link
Collaborator

Thank you, @geoffroy-noel-ddh, all good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants