Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Add how to guide on backing up and restoring rook-ceph volumes with Velero #1048

Merged
merged 4 commits into from
Oct 14, 2020
Merged

Add how to guide on backing up and restoring rook-ceph volumes with Velero #1048

merged 4 commits into from
Oct 14, 2020

Conversation

surajssd
Copy link
Member

@surajssd surajssd commented Oct 6, 2020 •
edited
Loading

TODOS:

  • Add conversion test.

Fixes #1038

@surajssd surajssd force-pushed the surajssd/document-velero-rook-ceph branch from 7195671 to 7963f44 Compare October 6, 2020 10:42
@surajssd
Copy link
Member Author

surajssd commented Oct 6, 2020 •
edited
Loading

I tested this with component prometheus-operator and it works.

Backup

kubectl -n monitoring annotate pod alertmanager-prometheus-operator-alertmanager-0 backup.velero.io/backup-volumes=data
kubectl -n monitoring annotate pod prometheus-prometheus-operator-prometheus-0 backup.velero.io/backup-volumes=data
velero backup create backup-monitoring --include-namespaces monitoring --wait

Restore

So to restore anew, following order should be followed:

  • Restore using velero.
  • Use lokoctl and apply the component configs again.
velero restore create --from-backup backup-monitoring
lokoctl comopnent apply prometheus-operator

@surajssd surajssd requested review from ipochi and johananl October 6, 2020 13:08
invidian
invidian suggested changes Oct 6, 2020
View reviewed changes
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits, overall looks good to me!

docs/how-to-guides/backup-rook-ceph-volumes.md Outdated Show resolved Hide resolved
docs/how-to-guides/backup-rook-ceph-volumes.md Outdated Show resolved Hide resolved
docs/how-to-guides/backup-rook-ceph-volumes.md Outdated Show resolved Hide resolved
docs/how-to-guides/backup-rook-ceph-volumes.md Show resolved Hide resolved
docs/how-to-guides/backup-rook-ceph-volumes.md Outdated Show resolved Hide resolved
@surajssd surajssd force-pushed the surajssd/document-velero-rook-ceph branch 2 times, most recently from a203faa to 1bb7062 Compare October 7, 2020 06:09
@surajssd surajssd requested a review from invidian October 7, 2020 06:56
invidian
invidian previously approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some extra suggestions, otherwise looks good to me 👍

docs/how-to-guides/backup-rook-ceph-volumes.md Show resolved Hide resolved
docs/how-to-guides/backup-rook-ceph-volumes.md Show resolved Hide resolved
@surajssd surajssd force-pushed the surajssd/document-velero-rook-ceph branch from 1bb7062 to d0178ee Compare October 7, 2020 07:14
invidian
invidian previously approved these changes Oct 7, 2020
View reviewed changes
@surajssd surajssd force-pushed the surajssd/document-velero-rook-ceph branch from d0178ee to 4acce5e Compare October 7, 2020 07:22
invidian
invidian previously approved these changes Oct 7, 2020
View reviewed changes
ipochi
ipochi previously approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@ipochi ipochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Wonderful work @surajssd

I left some suggestions.

docs/how-to-guides/backup-rook-ceph-volumes.md Outdated Show resolved Hide resolved
docs/how-to-guides/backup-rook-ceph-volumes.md Outdated Show resolved Hide resolved
docs/how-to-guides/backup-rook-ceph-volumes.md Outdated Show resolved Hide resolved
@surajssd
velero docs: Remove wrong parameter
edecb79 
The example config has a parameter, `provider`, which is invalid.

Signed-off-by: Suraj Deshmukh <[email protected]>
@surajssd
velero docs: Pin the docs to velero component version
3e55b93 
Signed-off-by: Suraj Deshmukh <[email protected]>
@surajssd
velero: Add region field to restic block
4158700 
This commit removes the hardcoding of region in `restic` provider from
`eu-west-1` to a parameterised variable `region` just like other
providers.

Signed-off-by: Suraj Deshmukh <[email protected]>
@surajssd
How to Guide: Add doc to backup rook-ceph using velero
e6610b5 
This doc demonstrates how a user can backup and restore volumes using
Velero.

Signed-off-by: Suraj Deshmukh <[email protected]>
@surajssd surajssd dismissed stale reviews from ipochi and invidian via e6610b5 October 14, 2020 07:13
@surajssd surajssd force-pushed the surajssd/document-velero-rook-ceph branch from 4acce5e to e6610b5 Compare October 14, 2020 07:13
ipochi
ipochi approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@ipochi ipochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@surajssd surajssd merged commit f77d135 into master Oct 14, 2020
@surajssd surajssd deleted the surajssd/document-velero-rook-ceph branch October 14, 2020 08:22
@surajssd surajssd mentioned this pull request Oct 14, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ipochi ipochi ipochi approved these changes

@invidian invidian invidian approved these changes

@johananl johananl Awaiting requested review from johananl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document backup and restore of rook-ceph volumes using Velero
3 participants
@surajssd @ipochi @invidian