Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

School name ordering; Default Auto Field fix #115

Merged
merged 2 commits into from
Oct 25, 2024
Merged

School name ordering; Default Auto Field fix #115

merged 2 commits into from
Oct 25, 2024

Conversation

iMark3000
Copy link
Contributor

Rolled back commit 09002bb from PR# 113. This commit didn't fix the issue it was intended to fix and got the headers of the High Health table (The school names) out of sync with the metrics.

Added DEFAULT_AUTO_FIELD to settings.py to take care of the following warning:

WARNINGS: accounts.Job: (models.W042) Auto-created primary key used when not defining a primary key type, by default 'django.db.models.AutoField'.

This warning comes from a feature added in Django 3.2 to customize the data type of auto generated primary keys.

@iMark3000 iMark3000 requested a review from nbwiener October 25, 2024 16:52
@iMark3000 iMark3000 merged commit 58c431f into main Oct 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants