Housekeeping: Add link between interface and implementation when compiling ts for easy jump to implementation #3754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuzzy3
added
the
ignore-for-release
jakobe
reviewed
Jan 15, 2025
…-map-for-quick-access-to-implementation
Fuzzy3
deleted the
housekeeping/create-typescript-declarions-map-for-quick-access-to-implementation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes no issue.
What is the new behavior?
When navigating to definition of function you are currently taken to the interface file instead of the actual implementation. This is annoying for the
(developer).
Other people have been annoyed too: microsoft/TypeScript#14479
Luckily the fix is easy as described here: microsoft/TypeScript#22658
Does this PR introduce a breaking change?
Are there any additional context?
Going to definition of IonicElementPartHelper:
Will take you to the d.ts. interface file:
And should take you to:
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Review
When the pull request has been approved it will be merged to
developby Team Kirby.