Added compatibility for Python3 #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert print to print() Use string and binary types from six Converted to absolute imports, somehow breaking Python2 All tests pass At least one file works (no thorough test suite for sample files)
Better use of tempfile to create files/dirs Use str.format() for Shapes text Check for Python 3 location with subprocess for LibreOffice Move to argparse from deprecated optparse Use ensure_text and ensure_str from six for compatibility Added other fixes for Python2/3 string/byte issues Use Counter to simplify entropy calculations Use txbxContent variables to track tag open/close Use find instead of index while walking through XML
|
I'll check this out. Shifting the whole project over to Python 3 would be great. Personally if it got to the point of being solid and stable in Python 3 I would be fine with dropping Python 2 support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes were made in a way to maintain backward compatibility, but I could not get the absolute imports to work with Python2.
All tests also pass, but a large number of input files was not available for thorough testing.