Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): added build & deploy composite #28

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

sactioswastioyono18
Copy link

@sactioswastioyono18 sactioswastioyono18 commented Dec 22, 2022

Tested in suramadu
https://github.com/kitabisa/suramadu/actions/runs/3755325002

Please review and approve so we can use main branch for build push deploy dev/stg/prod

The approach is created to standardize workflow that utilize

  • build
  • deploy

Some assumptions

  • Build can be used by build test workflow
  • Build test doesn't need to push docker image
  • Every build won't be pushed to GCR unless we want to deploy
  • Only in deploy action we include GCR & gCloud setup
  • For golang, action/go@v3 already provide caching capability so we don't need action/cache
    - uses: actions/setup-go@v3
      with:
        cache: ${{ inputs.cache }}
        cache-dependency-path: ${{ inputs.cache-dependency-path }}
        go-version: ${{ inputs.go-version }} # The Go version to download (if necessary) and use.

@sactioswastioyono18 sactioswastioyono18 requested a review from a team December 22, 2022 03:29
build/backend/action.yaml Outdated Show resolved Hide resolved
build/backend/action.yaml Show resolved Hide resolved
build/backend/action.yaml Show resolved Hide resolved
build/backend/action.yaml Show resolved Hide resolved

runs:
using: "composite"
steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tambahan checkout.

    - name: Checking out repository
      uses: actions/checkout@v3

deploy/backend/action.yaml Outdated Show resolved Hide resolved
@sactioswastioyono18
Copy link
Author

sactioswastioyono18 commented Dec 22, 2022

Jadi ini approachnya kayaknya kita pengen pisahin build ama deploy yang mana build ini bisa direuse juga oleh workflow untuk unit test

jadi kalo build ya build aja kayak unit test, kan gaperlu dipush ke docker imagenya makanya input gcr ama docker dan gcloud ga dipasang. Asumsinya ga kestiap build itu pasti butuh push, gitu sih

tapi deploy kan butuh build jadi pasti butuh push, makanya define action docker, gcloud dan gcrnya di deploy, makanya bentuk actionya skarang kayak gini

gimana menurut mas @dimzrio ?

@sactioswastioyono18
Copy link
Author

Kurefactor jadinya pas bagian build ada nerima parameter build-push-image ya

jadi bagian deploynya pure deploy aja
bagian buildnya klo parameter push true, baru dia ngepush image
dan bisa di reuse buat build test jg

@dmzrio
Copy link
Contributor

dmzrio commented Dec 23, 2022

Kurefactor jadinya pas bagian build ada nerima parameter build-push-image ya

jadi bagian deploynya pure deploy aja bagian buildnya klo parameter push true, baru dia ngepush image dan bisa di reuse buat build test jg

ah baru nangkep context nya. sory2, kmrin asumsi w perlakuannya kyk composite nya frontend. kg baca detail desc PR nya..haha
ok deh mas @sactioswastioyono18 , di tambahin input build-push-image aja. jadi composite nya bisa di pake ketika test sma build-push k gcr. mantaps2

@dmzrio dmzrio self-requested a review December 23, 2022 06:07
@sactioswastioyono18 sactioswastioyono18 merged commit 76bf278 into main Dec 23, 2022
@sactioswastioyono18 sactioswastioyono18 deleted the feat/backend-build-ci branch December 23, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants