Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cdn compatibility for monorepo #47

Merged
merged 1 commit into from
Mar 28, 2023
Merged

fix: cdn compatibility for monorepo #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion build/frontend/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,5 +236,4 @@ runs:
cdn_aws_access_key_id: ${{ inputs.cdn_aws_access_key_id }}
cdn_aws_secret_access_key: ${{ inputs.cdn_aws_secret_access_key }}
cdn_aws_region: ${{ inputs.cdn_aws_region }}
cdn_source_dir: ${{ inputs.cdn_source_dir }}
delete: ${{ steps.build-push.outputs.cdn-delete-path }}
25 changes: 24 additions & 1 deletion destroy/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,30 @@ inputs:
default: true
type: boolean

cdn_aws_s3_bucket:
required: false
description: "CDN aws s3 bucket"
default: ""
type: string

cdn_aws_access_key_id:
required: false
description: "CDN aws access key id"
default: ""
type: string

cdn_aws_secret_access_key:
required: false
description: "CDN aws secret access key"
default: ""
type: string

cdn_aws_region:
required: false
description: "CDN aws region"
default: ""
type: string

runs:
using: "composite"
steps:
Expand Down Expand Up @@ -90,5 +114,4 @@ runs:
cdn_aws_access_key_id: ${{ inputs.cdn_aws_access_key_id }}
cdn_aws_secret_access_key: ${{ inputs.cdn_aws_secret_access_key }}
cdn_aws_region: ${{ inputs.cdn_aws_region }}
cdn_source_dir: ${{ inputs.cdn_source_dir }}
delete: ${{ steps.destroy-release.outputs.cdn-delete-path }}
11 changes: 4 additions & 7 deletions packages/cdn/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,27 +9,24 @@ inputs:
type: string

cdn_aws_s3_bucket:
required: false
required: true
description: "CDN aws s3 bucket"
default: ""
type: string

cdn_aws_access_key_id:
required: false
required: true
description: "CDN aws access key id"
default: ""
type: string

cdn_aws_secret_access_key:
required: false
required: true
description: "CDN aws secret access key"
default: ""
type: string

cdn_aws_region:
required: false
required: true
description: "CDN aws region"
default: ""
type: string

cdn_source_dir:
Expand Down
12 changes: 6 additions & 6 deletions tools/frontend/nextjs-bundle-analysis/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,14 @@ runs:

- name: Download base branch bundle stats
uses: dawidd6/action-download-artifact@v2
if: success() && ${{ inputs.pr_number != '' }}
if: success() && inputs.pr_number != ''
with:
workflow: ${{ inputs.workflow_name }}
branch: ${{ inputs.base_branch }}
path: ${{ inputs.working_directory }}/.next/analyze/base

- name: Compare with base branch bundle
if: success() && ${{ inputs.pr_number != '' }}
if: success() && inputs.pr_number != ''
run: |
ls -laR .next/analyze/base && npx -p nextjs-bundle-analysis compare
sed -i 's/Next.js Bundle Analysis/${{ inputs.comment_header }}/g' .next/analyze/__bundle_analysis_comment.txt
Expand All @@ -62,7 +62,7 @@ runs:

- name: Get comment body
id: get-comment-body
if: success() && ${{ inputs.pr_number != '' }}
if: success() && inputs.pr_number != ''
uses: actions/github-script@v6
with:
result-encoding: string
Expand All @@ -73,22 +73,22 @@ runs:

- name: Find Comment
uses: peter-evans/find-comment@v2
if: success() && ${{ inputs.pr_number != '' }}
if: success() && inputs.pr_number != ''
id: fc
with:
issue-number: ${{ inputs.pr_number }}
body-includes: "${{ inputs.comment_header }}"

- name: Create Comment
uses: peter-evans/create-or-update-comment@v2
if: success() && ${{ inputs.pr_number != '' }} && steps.fc.outputs.comment-id == 0
if: success() && inputs.pr_number != '' && steps.fc.outputs.comment-id == 0
with:
issue-number: ${{ inputs.pr_number }}
body: ${{ steps.get-comment-body.outputs.body }}

- name: Update Comment
uses: peter-evans/create-or-update-comment@v2
if: success() && ${{ inputs.pr_number != '' }} && steps.fc.outputs.comment-id != 0
if: success() && inputs.pr_number != '' && steps.fc.outputs.comment-id != 0
with:
issue-number: ${{ inputs.pr_number }}
body: ${{ steps.get-comment-body.outputs.body }}
Expand Down